Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: webkit/plugins/ppapi/resource_creation_impl.h

Issue 10544089: Implement the file chooser as a new resource "host" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/ppb_file_ref_impl.h ('k') | webkit/plugins/ppapi/resource_creation_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/resource_creation_impl.h
diff --git a/webkit/plugins/ppapi/resource_creation_impl.h b/webkit/plugins/ppapi/resource_creation_impl.h
index e22e9e6f5b9728807bf49b06d24510481f3b8cd9..05722d5ee90aff5943b7cdbaad419b5067dab1ab 100644
--- a/webkit/plugins/ppapi/resource_creation_impl.h
+++ b/webkit/plugins/ppapi/resource_creation_impl.h
@@ -8,13 +8,15 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "ppapi/thunk/resource_creation_api.h"
+#include "webkit/plugins/webkit_plugins_export.h"
namespace webkit {
namespace ppapi {
class PluginInstance;
-class ResourceCreationImpl : public ::ppapi::thunk::ResourceCreationAPI {
+class WEBKIT_PLUGINS_EXPORT ResourceCreationImpl
+ : public NON_EXPORTED_BASE(::ppapi::thunk::ResourceCreationAPI) {
public:
explicit ResourceCreationImpl(PluginInstance* instance);
virtual ~ResourceCreationImpl();
@@ -41,10 +43,6 @@ class ResourceCreationImpl : public ::ppapi::thunk::ResourceCreationAPI {
virtual PP_Resource CreateBuffer(PP_Instance instance,
uint32_t size) OVERRIDE;
virtual PP_Resource CreateDirectoryReader(PP_Resource directory_ref) OVERRIDE;
- virtual PP_Resource CreateFileChooser(
- PP_Instance instance,
- PP_FileChooserMode_Dev mode,
- const char* accept_types) OVERRIDE;
virtual PP_Resource CreateFileIO(PP_Instance instance) OVERRIDE;
virtual PP_Resource CreateFileRef(PP_Resource file_system,
const char* path) OVERRIDE;
« no previous file with comments | « webkit/plugins/ppapi/ppb_file_ref_impl.h ('k') | webkit/plugins/ppapi/resource_creation_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698