Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: corelib/src/future.dart

Issue 10544063: More tests and doc for futures (followup to http://codereview.chromium.org/10517006/) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/corelib/future_test.dart » ('j') | tests/corelib/future_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: corelib/src/future.dart
===================================================================
--- corelib/src/future.dart (revision 8412)
+++ corelib/src/future.dart (working copy)
@@ -19,7 +19,7 @@
* (producing an exception, which may be handled with [handleException]).
* Callbacks passed to [onComplete] will be invoked in either case.
*
- * When a future completes:
+ * When a future completes, the following actions happen in order:
*
* 1. if the future suceeded, handlers registered with [then] are called.
* 2. if the future failed, handlers registered with [handleException] are
@@ -69,7 +69,7 @@
* If this future is complete and has a value, then [onValue] is called
* with the value.
*/
- void then(void onValue(T value));
+ void then(void onSuccess(T value));
/**
* If this future is complete and has an exception, then call [onException].
« no previous file with comments | « no previous file | tests/corelib/future_test.dart » ('j') | tests/corelib/future_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698