Issue 10544063: More tests and doc for futures (followup to http://codereview.chromium.org/10517006/)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10544063: More tests and doc for futures (followup to http://codereview.chromium.org/10517006/)

Created:
8 years, 6 months ago by sammccall

Modified:
7 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More tests and doc for futures (followup to http://codereview.chromium.org/10517006/)

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -2 lines)			Patch
	M	corelib/src/future.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	tests/corelib/future_test.dart	View	1 2	3 chunks	+104 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

Thanks Sam! LGTM http://codereview.chromium.org/10544063/diff/2001/tests/corelib/future_test.dart File tests/corelib/future_test.dart (right): http://codereview.chromium.org/10544063/diff/2001/tests/corelib/future_test.dart#newcode508 tests/corelib/future_test.dart:508: completer.future.chain((x) => new Future<int>.immediate(43)).handleException((e) { 80 ...

8 years, 6 months ago (2012-06-07 23:29:59 UTC) #1

sammccall

Oops, thanks! Please commit if this looks good. http://codereview.chromium.org/10544063/diff/2001/tests/corelib/future_test.dart File tests/corelib/future_test.dart (right): http://codereview.chromium.org/10544063/diff/2001/tests/corelib/future_test.dart#newcode508 tests/corelib/future_test.dart:508: completer.future.chain((x) ...

8 years, 6 months ago (2012-06-07 23:41:04 UTC) #2

thanks! submitted in r8448

Expand Messages | Collapse Messages

Issue 10544063: More tests and doc for futures (followup to http://codereview.chromium.org/10517006/)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages