Aura: Add Window::MoveCursorTo() taking relative location to the window.

ui/aura/window_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/window.h"
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/stringprintf.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/aura/client/capture_client.h"
 #include "ui/aura/client/stacking_client.h"
 #include "ui/aura/client/visibility_client.h"
 #include "ui/aura/event.h"
 #include "ui/aura/layout_manager.h"
 #include "ui/aura/root_window.h"
+#include "ui/aura/root_window_host.h"
 #include "ui/aura/root_window_observer.h"
 #include "ui/aura/test/aura_test_base.h"
 #include "ui/aura/test/event_generator.h"
 #include "ui/aura/test/test_window_delegate.h"
 #include "ui/aura/test/test_windows.h"
 #include "ui/aura/window_delegate.h"
 #include "ui/aura/window_observer.h"
 #include "ui/aura/window_property.h"
 #include "ui/base/gestures/gesture_configuration.h"
 #include "ui/base/hit_test.h"
@@ skipping 268 matching lines @@
   // Window::ConvertPointToWindow is mostly identical to
   // Layer::ConvertPointToLayer, except NULL values for |source| are permitted,
   // in which case the function just returns.
   scoped_ptr<Window> w1(CreateTestWindowWithId(1, NULL));
   gfx::Point reference_point(100, 100);
   gfx::Point test_point = reference_point;
   Window::ConvertPointToWindow(NULL, w1.get(), &test_point);
   EXPECT_EQ(reference_point, test_point);
 }
 
+TEST_F(WindowTest, MoveCursorTo) {
+  scoped_ptr<Window> w1(
+      CreateTestWindow(SK_ColorWHITE, 1, gfx::Rect(10, 10, 500, 500), NULL));
+  scoped_ptr<Window> w11(
+      CreateTestWindow(SK_ColorGREEN, 11, gfx::Rect(5, 5, 100, 100), w1.get()));
+  scoped_ptr<Window> w111(
+      CreateTestWindow(SK_ColorCYAN, 111, gfx::Rect(5, 5, 75, 75), w11.get()));
+  scoped_ptr<Window> w1111(
+      CreateTestWindow(SK_ColorRED, 1111, gfx::Rect(5, 5, 50, 50), w111.get()));
+
+  RootWindow* root = root_window();
+  root->MoveCursorTo(gfx::Point(10, 10));
+  EXPECT_EQ(gfx::Point(10, 10), root->last_mouse_location());

[oshima, 2012/06/15 16:57:01]

could you please use the style
EXPECT_EQ("10,10", root->last_mouse_location().ToString());
?
This makes it easier to read error messages.

[yoshiki, 2012/06/18 06:55:36]

Done.

+  w1->MoveCursorTo(gfx::Point(10, 10));
+  EXPECT_EQ(gfx::Point(20, 20), root->last_mouse_location());
+  w11->MoveCursorTo(gfx::Point(10, 10));
+  EXPECT_EQ(gfx::Point(25, 25), root->last_mouse_location());
+  w111->MoveCursorTo(gfx::Point(10, 10));
+  EXPECT_EQ(gfx::Point(30, 30), root->last_mouse_location());
+  w1111->MoveCursorTo(gfx::Point(10, 10));
+  EXPECT_EQ(gfx::Point(35, 35), root->last_mouse_location());
+
+  // Test with transform to root_window.
+  ui::Transform transform0;
+  transform0.ConcatScale(2, 5);
+  transform0.ConcatTranslate(10, -20);
+  transform0.ConcatRotate(-45.0f);

[oshima, 2012/06/15 16:57:01]

non orthogonal angles makes it difficult to verify that this test is correct.
Just use -90. same for others.

[yoshiki, 2012/06/18 06:55:36]

Done.

+  root->SetTransform(transform0);
+  root->MoveCursorTo(gfx::Point(10, 10));
+  EXPECT_EQ(gfx::Point(42, 0), root->host()->QueryMouseLocation());
+  EXPECT_EQ(gfx::Point(10, 10), root->last_mouse_location());
+
+  // Tests with transform to windows.
+  ui::Transform transform1;
+  transform1.ConcatScale(2, 2);
+  w1->SetTransform(transform1);
+  w1->MoveCursorTo(gfx::Point(10, 10));
+  EXPECT_EQ(gfx::Point(30, 30), root->last_mouse_location());
+
+  ui::Transform transform2;
+  transform2.ConcatTranslate(-10, 20);
+  w11->SetTransform(transform2);
+  w11->MoveCursorTo(gfx::Point(10, 10));
+  EXPECT_EQ(gfx::Point(20, 80), root->last_mouse_location());
+
+  ui::Transform transform3;
+  transform3.ConcatRotate(45.0f);
+  w111->SetTransform(transform3);
+  w111->MoveCursorTo(gfx::Point(10, 10));
+  EXPECT_EQ(gfx::Point(10, 98), root->last_mouse_location());
+
+  ui::Transform transform4;
+  transform4.ConcatScale(0.3f, 0.5f);
+  transform4.ConcatRotate(120.0f);
+  transform4.ConcatTranslate(-10, -20);
+  w1111->SetTransform(transform4);
+  w1111->MoveCursorTo(gfx::Point(10, 10));
+  EXPECT_EQ(gfx::Point(15, 33), root->last_mouse_location());

[oshima, 2012/06/15 16:57:01]

It's hard to tell these tests are correct. It'd be better to keep test for
complex transforms and test for multiple transforms separated.

[yoshiki, 2012/06/18 06:55:36]

Done.

+}
+
 TEST_F(WindowTest, HitTest) {
   Window w1(new ColorTestWindowDelegate(SK_ColorWHITE));
   w1.set_id(1);
   w1.Init(ui::LAYER_TEXTURED);
   w1.SetBounds(gfx::Rect(10, 20, 50, 60));
   w1.Show();
   w1.SetParent(NULL);
 
   // Points are in the Window's coordinates.
   EXPECT_TRUE(w1.HitTest(gfx::Point(1, 1)));
@@ skipping 1974 matching lines @@
   element->Step(start_time + base::TimeDelta::FromMilliseconds(1000));
 
   // No bounds changed notification at the end of animation since layer
   // delegate is NULL.
   EXPECT_FALSE(delegate.bounds_changed());
   EXPECT_NE("0,0 100x100", window->bounds().ToString());
 }
 
 }  // namespace test
 }  // namespace aura