Do not toggle Applist with Search key press when accessibility is enabled.

ash/accelerators/accelerator_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_controller.h"
 
 #include "ash/accelerators/accelerator_table.h"
 #include "ash/ash_switches.h"
 #include "ash/caps_lock_delegate.h"
 #include "ash/desktop_background/desktop_background_controller.h"
@@ skipping 341 matching lines @@
       // Return true to prevent propagation of the key event.
       return true;
     case TAKE_PARTIAL_SCREENSHOT:
       if (screenshot_delegate_.get())
         ash::Shell::GetInstance()->delegate()->
             StartPartialScreenshot(screenshot_delegate_.get());
       // Return true to prevent propagation of the key event because
       // this key combination is reserved for partial screenshot.
       return true;
     case TOGGLE_APP_LIST:
+      // When spoken feedback is enabled, we should neither toggle the list nor
+      // consume the key since Search+Shift is one of the shortcuts the a11y
+      // feature uses. crbug.com/132296
+      if (Shell::GetInstance()->delegate()->IsSpokenFeedbackEnabled())

[Zachary Kuznia, 2012/06/14 10:02:22]

Perhaps we should DCHECK that the accelerator being pressed is the search key? 
We don't want this to mask other accelerators.

[Yusuke Sato, 2012/06/14 11:41:40]

Done.

+        return false;
       ash::Shell::GetInstance()->ToggleAppList();
       return true;
     case TOGGLE_CAPS_LOCK:
       if (caps_lock_delegate_.get())
         return caps_lock_delegate_->HandleToggleCapsLock();
       break;
     case BRIGHTNESS_DOWN:
       if (brightness_control_delegate_.get())
         return brightness_control_delegate_->HandleBrightnessDown(accelerator);
       break;
@@ skipping 217 matching lines @@
     // Then set this one as active.
     Shell::GetInstance()->launcher()->ActivateLauncherItem(found_index);
   }
 }
 
 bool AcceleratorController::CanHandleAccelerators() const {
   return true;
 }
 
 }  // namespace ash