Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7316)

Unified Diff: chrome/renderer/chrome_render_process_observer.cc

Issue 10543146: Use NSS for symmetric key crypto operations on Windows and Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed Windows shared library build (also need NSS DEPS roll) Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | crypto/crypto.gyp » ('j') | crypto/crypto.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_render_process_observer.cc
diff --git a/chrome/renderer/chrome_render_process_observer.cc b/chrome/renderer/chrome_render_process_observer.cc
index 4a2a97ca6b935d005ba7d836adfef03d94f31a44..561e425311173e894c97d3161bd00c97ce01ad7b 100644
--- a/chrome/renderer/chrome_render_process_observer.cc
+++ b/chrome/renderer/chrome_render_process_observer.cc
@@ -186,7 +186,8 @@ ChromeRenderProcessObserver::ChromeRenderProcessObserver(
#endif
#if defined(OS_POSIX) && !defined(OS_MACOSX) && defined(USE_NSS)
- // Remoting requires NSS to function properly.
+ // On Linux, NSS uses system libraries, so the .so's must be loaded.
Nick Bray 2012/06/14 20:37:06 On a side note, ChromeOS uses a patched version of
Ryan Sleevi 2012/06/14 20:54:48 Do you have an example of this? Chrome on Linux/C
+ // (On all platforms, RNG is primed in WebKit (for window.crypto.getRandom()).
Ryan Sleevi 2012/06/14 19:35:26 You can remove this second comment.
ddorwin 2012/06/14 20:44:19 Done.
if (!command_line.HasSwitch(switches::kSingleProcess)) {
// We are going to fork to engage the sandbox and we have not loaded
// any security modules so it is safe to disable the fork check in NSS.
« no previous file with comments | « no previous file | crypto/crypto.gyp » ('j') | crypto/crypto.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698