Add an explicit function to init NSS for SSL server sockets

net/socket/nss_ssl_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is only included in ssl_client_socket_nss.cc and
 // ssl_server_socket_nss.cc to share common functions of NSS.
 
 #ifndef NET_SOCKET_NSS_SSL_UTIL_H_
 #define NET_SOCKET_NSS_SSL_UTIL_H_
 
-#include <prerror.h>
+#include "net/base/net_export.h"
 
 namespace net {
 
-class BoundNetLog;
-
-// Initalize NSS SSL library.
+// Initialize NSS SSL library.

[Wez, 2012/06/12 17:27:13]

Can you clarify what level of initialization this provides? From the layout you
have here, it's not clear that EnsureNSSSSLServerInit() does more than
EnsureNSSSSLInit() alone, rather than the other way around.
(Oh, and these function names are horrible. ):

[Ryan Sleevi, 2012/06/12 17:45:29]

Yup. We've had the style discussion as to whether NSS or Nss is the preferred
means. Same with SSL vs Ssl.

The closest the style guide gets to naming is in the 'enhanced' Chromium style
guide ( http://dev.chromium.org/developers/coding-style ), which reads "Prefer
to capitalize well-known abbreviations as if they were words: HttpUrl instead of
HTTPURL". SSL may be well known, but is NSS?

The style for both has been all caps (SSLClientSocketNSS), hence keeping up with
the style.

 void EnsureNSSSSLInit();
 
-// Log a failed NSS funcion call.
-void LogFailedNSSFunction(const BoundNetLog& net_log,
-                          const char* function,
-                          const char* param);
-
-// Map network error code to NSS error code.
-PRErrorCode MapErrorToNSS(int result);
-
-// Map NSS error code to network error code.
-int MapNSSError(PRErrorCode err);
+// Initialize NSS SSL server sockets support.

[wtc, 2012/06/12 18:27:38]

We should document why this needs to be initialized separately
(server side code is not always used), and that this needs to
be called early to accomplish the "early init" effect.

+NET_EXPORT void EnsureNSSSSLServerInit();
 
 }  // namespace net
 
 #endif  // NET_SOCKET_NSS_SSL_UTIL_H_