Add an explicit function to init NSS for SSL server sockets

remoting/client/plugin/chromoting_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/chromoting_instance.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/stringprintf.h"
 #include "base/string_split.h"
 #include "base/synchronization/lock.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/threading/thread.h"
 #include "base/values.h"
 #include "jingle/glue/thread_wrapper.h"
 #include "media/base/media.h"
+#include "net/socket/ssl_server_socket.h"
 #include "ppapi/cpp/completion_callback.h"
 #include "ppapi/cpp/input_event.h"
 #include "ppapi/cpp/mouse_cursor.h"
 #include "ppapi/cpp/rect.h"
 #include "remoting/base/constants.h"
 #include "remoting/base/util.h"
 #include "remoting/client/client_config.h"
 #include "remoting/client/chromoting_client.h"
 #include "remoting/client/frame_consumer_proxy.h"
 #include "remoting/client/plugin/pepper_input_handler.h"
@@ skipping 146 matching lines @@
 
   VLOG(1) << "Started ChromotingInstance::Init";
 
   // Check to make sure the media library is initialized.
   // http://crbug.com/91521.
   if (!media::IsMediaLibraryInitialized()) {
     LOG(ERROR) << "Media library not initialized.";
     return false;
   }
 
+  net::EnableSSLServerSockets();

[Wez, 2012/06/12 21:30:35]

In practice I doubt it's an issue, but the Chromoting PPAPI plugin currently
runs in the renderer, which may contain other threads that could trigger an
action on an SSL server socket.

[Wez, 2012/06/12 21:30:35]

nit: Add a comment to explain why we need to have the call at this point.

[Ryan Sleevi, 2012/06/12 22:35:40]

Right. I was trying to find where the post-sandbox Renderer init code lives. The
Pre-sandbox code configures NSS (for all renderer types), so it would make sense
that the post-sandbox code would initialize the server sockets.

If it is an issue though, we'll hit the DCHECK right away.

+
   // Start all the threads.
   context_.Start();
 
   // Create the chromoting objects that don't depend on the network connection.
   // RectangleUpdateDecoder runs on a separate thread so for now we wrap
   // PepperView with a ref-counted proxy object.
   scoped_refptr<FrameConsumerProxy> consumer_proxy =
       new FrameConsumerProxy(plugin_message_loop_);
   rectangle_decoder_ = new RectangleUpdateDecoder(
       context_.decode_message_loop(), consumer_proxy);
@@ skipping 500 matching lines @@
   PostChromotingMessage("logDebugMessage", data.Pass());
   g_logging_to_plugin = false;
 }
 
 bool ChromotingInstance::IsConnected() {
   return host_connection_.get() &&
     (host_connection_->state() == protocol::ConnectionToHost::CONNECTED);
 }
 
 }  // namespace remoting