src/arm/lithium-codegen-arm.cc - Issue 10543094: Eliminate redundant smi checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 10543094: Eliminate redundant smi checks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Review feedback Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 8f10008e88d933cf82c2beb77947f7b33510bffb..38641874b6c3c45f0df0ed9d5eb4bde77bf3ec03 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -2753,9 +2753,14 @@ void LCodeGen::DoLoadKeyedFastElement(LLoadKeyedFastElement* instr) {

// Check for the hole value.

if (instr->hydrogen()->RequiresHoleCheck()) {

- __ LoadRoot(scratch, Heap::kTheHoleValueRootIndex);

- __ cmp(result, scratch);

- DeoptimizeIf(eq, instr->environment());

+ if (IsFastSmiElementsKind(instr->hydrogen()->elements_kind())) {

+ __ tst(result, Operand(kSmiTagMask));

+ DeoptimizeIf(ne, instr->environment());

+ } else {

+ __ LoadRoot(scratch, Heap::kTheHoleValueRootIndex);

+ __ cmp(result, scratch);

+ DeoptimizeIf(eq, instr->environment());

+ }

}