chrome/browser/net/chrome_network_delegate.cc - Issue 10542153: NetLogEventParameter to Callback refactoring 11.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 10542153: NetLogEventParameter to Callback refactoring 11. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/chrome_network_delegate.cc

===================================================================

--- chrome/browser/net/chrome_network_delegate.cc (revision 142108)

+++ chrome/browser/net/chrome_network_delegate.cc (working copy)

@@ -169,10 +169,9 @@

if (url_blacklist_manager_ &&

url_blacklist_manager_->IsURLBlocked(request->url())) {

// URL access blocked by policy.

- scoped_refptr<net::NetLog::EventParameters> params;

- params = new net::NetLogStringParameter("url", request->url().spec());

request->net_log().AddEvent(

- net::NetLog::TYPE_CHROME_POLICY_ABORTED_REQUEST, params);

+ net::NetLog::TYPE_CHROME_POLICY_ABORTED_REQUEST,

+ net::NetLog::StringCallback("url", &request->url().spec()));

eroman 2012/06/14 18:04:31 nit: might want to use possibly_invalid_spec() jus

mmenke 2012/06/14 18:49:42 Done.

return net::ERR_NETWORK_ACCESS_DENIED;

}

#endif

@@ -379,10 +378,9 @@

if (url_blacklist_manager_ &&

url_blacklist_manager_->IsURLBlocked(socket->url())) {

// URL access blocked by policy.

- scoped_refptr<net::NetLog::EventParameters> params;

- params = new net::NetLogStringParameter("url", socket->url().spec());

socket->net_log()->AddEvent(

- net::NetLog::TYPE_CHROME_POLICY_ABORTED_REQUEST, params);

+ net::NetLog::TYPE_CHROME_POLICY_ABORTED_REQUEST,

+ net::NetLog::StringCallback("url", &socket->url().spec()));

eroman 2012/06/14 18:04:31 ditto.

mmenke 2012/06/14 18:49:42 Done.

return net::ERR_NETWORK_ACCESS_DENIED;

}

#endif