Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Unified Diff: ppapi/shared_impl/var_tracker.h

Issue 10542150: Actually free plugin implement vars when running out of process when the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ppapi/proxy/ppp_class_proxy.cc ('K') | « ppapi/shared_impl/test_globals.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/var_tracker.h
===================================================================
--- ppapi/shared_impl/var_tracker.h (revision 141525)
+++ ppapi/shared_impl/var_tracker.h (working copy)
@@ -11,6 +11,7 @@
#include "base/hash_tables.h"
#include "base/memory/ref_counted.h"
#include "base/threading/non_thread_safe.h"
+#include "ppapi/c/pp_instance.h"
#include "ppapi/c/pp_module.h"
#include "ppapi/c/pp_var.h"
#include "ppapi/shared_impl/ppapi_shared_export.h"
@@ -33,7 +34,7 @@
// anything with it other than call virtual functions. The interesting parts
// are added by the PluginObjectVar derived from this class.
class PPAPI_SHARED_EXPORT VarTracker
-#ifdef ENABLE_PEPPER_THREADING
+#if 1//def ENABLE_PEPPER_THREADING
viettrungluu 2012/06/15 21:55:52 wtf?
: NON_EXPORTED_BASE(public base::NonThreadSafeDoNothing) {
#else
// TODO(dmichael): Remove the thread checking when calls are allowed off the
@@ -84,6 +85,9 @@
int GetRefCountForObject(const PP_Var& object);
int GetTrackedWithNoReferenceCountForObject(const PP_Var& object);
+ // Called after an instance is deleted to do var cleanup.
+ virtual void DidDeleteInstance(PP_Instance instance) = 0;
+
protected:
struct VarInfo {
VarInfo();
« ppapi/proxy/ppp_class_proxy.cc ('K') | « ppapi/shared_impl/test_globals.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698