Issue 10542137: Fix r11780 to avoid bugs where near branches are used to labels that are out of range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10542137: Fix r11780 to avoid bugs where near branches are used to labels that are out of range. (Closed)

Created:
8 years, 6 months ago by Erik Corry

Modified:
8 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix r11780 to avoid bugs where near branches are used to labels that are out of range. Committed: http://code.google.com/p/v8/source/detail?r=11792

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -22 lines)			Patch
M	src/ia32/lithium-codegen-ia32.cc	View	1	3 chunks	+19 lines, -11 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	3 chunks	+19 lines, -11 lines	0 comments	Download
A	test/mjsunit/regress/regress-deep-proto.js	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 6 months ago (2012-06-13 09:49:57 UTC) #2

LGTM.

http://codereview.chromium.org/10542137/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/10542137/diff/1/src/x64/lithium-codegen-x64.cc...
src/x64/lithium-codegen-x64.cc:2281: CompactEmit(instr->hydrogen()->types(),
name, i, isolate());
This basically means we need to do three lookups (instead of two) for each type
in the polymorphic dispatch. If that overhead is acceptable I am fine with this
implementation, because it's clean.

Expand Messages | Collapse Messages