Issue 10542076: ABANDONED: chromeos: Download contacts (work in progress).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10542076: ABANDONED: chromeos: Download contacts (work in progress). (Closed)

Created:
8 years, 6 months ago by Daniel Erat

Modified:
8 years ago

Reviewers:

CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

(All of this code has been landed now.) chromeos: Download contacts (work in progress). BUG=128805 TEST=

Patch Set 1 #

Patch Set 2 : hackety hackety #

Patch Set 3 : more changes #

Patch Set 4 : add syncing #

Patch Set 5 : start adding database #

Patch Set 6 : added database test; basic save and restore working #

Patch Set 7 : save and load photos #

Patch Set 8 : lots more test-related work #

Patch Set 9 : phone numbers and more tests #

Patch Set 10 : add browser test for GDataContactsService #

Patch Set 11 : hack things together so results show up in app list #

Patch Set 12 : fix a few synchronization issues during shutdown #

Patch Set 13 : drop title field, switch to regexes for date-parsing, ditch linked_ptr #

Patch Set 14 : ContactSourceObserver, fail on photo errors, add more feed tests #

Patch Set 15 : remove ParseRFC3339DateTime and rename FormatTimeAsRFC3339DateTime to FormatTimeAsString #

Patch Set 16 : minor changes #

Patch Set 17 : using protobufs and leveldb #

Patch Set 18 : more changes #

Patch Set 19 : add more GoogleContactStore tests #

Patch Set 20 : pass profiles into ContactManager #

Patch Set 21 : start adding ContactManager tests #

Patch Set 22 : ui work; most download code landed #

Patch Set 23 : add (non-functional) action icons to app list results #

Patch Set 24 : more ui changes #

Patch Set 25 : ContactProvider cleanup and tests #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+812 lines, -0 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_controller.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21	3 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	2 chunks	+2 lines, -0 lines	0 comments	Download
A	chrome/browser/autocomplete/contact_provider_chromeos.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	1 chunk	+93 lines, -0 lines	0 comments	Download
A	chrome/browser/autocomplete/contact_provider_chromeos.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	1 chunk	+313 lines, -0 lines	0 comments	Download
A	chrome/browser/autocomplete/contact_provider_chromeos_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	1 chunk	+282 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/search_builder.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/search_builder.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	8 chunks	+97 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24	1 chunk	+1 line, -0 lines	0 comments	Download