[Sync] Remove unnecessary posting of methods in sync scheduler.

sync/engine/sync_scheduler.h

Index: sync/engine/sync_scheduler.h
diff --git a/sync/engine/sync_scheduler.h b/sync/engine/sync_scheduler.h
index dfd63e4a0b4306f79cf10154156e689f73c8a9b8..33f75957707ebe720fa7750e7348166df1f2a3af 100644
--- a/sync/engine/sync_scheduler.h
+++ b/sync/engine/sync_scheduler.h
@@ -87,16 +87,13 @@ class SyncScheduler : public sessions::SyncSession::Delegate {
 
   // Note: The source argument of this function must come from the subset of
   // GetUpdatesCallerInfo values related to configurations.
-  void ScheduleConfig(
+  void Configure(

[tim (not reviewing), 2012/06/11 20:06:13]

I'm not sure about this rename -- it is still up to the scheduler to choose to
not actually perform the job (see WaitInterval::pending_configure_job). Granted,
we should have a more graceful way of handling this (also see bug 46078), but
from an API point of view the truth is the scheduler makes no guarantee that
anything _will happen immediately_.

(side note - I don't like 'Configure' just 'cause it sounds like we're
configuring the scheduler or something. And we have way too many 'Configure'
methods to begin with.)

I think there may have been some confusion with the reconfig prod issue from
last year, but in that case we weren't actually in backoff because
MIGRATION_DONE isn't an error worthy of backoff.  The loop (IIRC) was
(MIGRATION_DONE > CONFIGURATION)*

[Nicolas Zea, 2012/06/11 20:55:09]

Done.

       syncable::ModelTypeSet types,
       sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source);
 
-  void ScheduleClearUserData();
-  // If this is called before Start(), the cleanup is guaranteed to
-  // happen before the Start finishes.
-  //
-  // TODO(akalin): Figure out how to test this.
-  void ScheduleCleanupDisabledTypes();
+  void ClearUserData();
+
+  void CleanupDisabledTypes();

[tim (not reviewing), 2012/06/11 20:06:13]

nit - You can add a TODO here for me and note bug 131336

[Nicolas Zea, 2012/06/11 20:55:09]

Done.

 
   // Change status of notifications in the SyncSessionContext.
   void set_notifications_enabled(bool notifications_enabled);
@@ -310,17 +307,12 @@ class SyncScheduler : public sessions::SyncSession::Delegate {
 
   // 'Impl' here refers to real implementation of public functions, running on
   // |thread_|.
-  void StartImpl(Mode mode, const base::Closure& callback);
   void StopImpl(const base::Closure& callback);
   void ScheduleNudgeImpl(
       const base::TimeDelta& delay,
       sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source,
       const syncable::ModelTypePayloadMap& types_with_payloads,
       bool is_canary_job, const tracked_objects::Location& nudge_location);
-  void ScheduleConfigImpl(const ModelSafeRoutingInfo& routing_info,
-      const std::vector<ModelSafeWorker*>& workers,
-      const sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source);
-  void ScheduleClearUserDataImpl();
 
   // Returns true if the client is currently in exponential backoff.
   bool IsBackingOff() const;