[Sync] Remove unnecessary posting of methods in sync scheduler.

sync/engine/sync_scheduler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A class to schedule syncer tasks intelligently.
 #ifndef SYNC_ENGINE_SYNC_SCHEDULER_H_
 #define SYNC_ENGINE_SYNC_SCHEDULER_H_
 #pragma once
 
 #include <string>
@@ skipping 69 matching lines @@
   void ScheduleNudge(const base::TimeDelta& delay, NudgeSource source,
                      syncable::ModelTypeSet types,
                      const tracked_objects::Location& nudge_location);
   void ScheduleNudgeWithPayloads(
       const base::TimeDelta& delay, NudgeSource source,
       const syncable::ModelTypePayloadMap& types_with_payloads,
       const tracked_objects::Location& nudge_location);
 
   // Note: The source argument of this function must come from the subset of
   // GetUpdatesCallerInfo values related to configurations.
-  void ScheduleConfig(
+  void Configure(

[tim (not reviewing), 2012/06/11 20:06:13]

I'm not sure about this rename -- it is still up to the scheduler to choose to
not actually perform the job (see WaitInterval::pending_configure_job). Granted,
we should have a more graceful way of handling this (also see bug 46078), but
from an API point of view the truth is the scheduler makes no guarantee that
anything _will happen immediately_.

(side note - I don't like 'Configure' just 'cause it sounds like we're
configuring the scheduler or something. And we have way too many 'Configure'
methods to begin with.)

I think there may have been some confusion with the reconfig prod issue from
last year, but in that case we weren't actually in backoff because
MIGRATION_DONE isn't an error worthy of backoff.  The loop (IIRC) was
(MIGRATION_DONE > CONFIGURATION)*

[Nicolas Zea, 2012/06/11 20:55:09]

Done.

       syncable::ModelTypeSet types,
       sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source);
 
-  void ScheduleClearUserData();
-  // If this is called before Start(), the cleanup is guaranteed to
-  // happen before the Start finishes.
-  //
-  // TODO(akalin): Figure out how to test this.
-  void ScheduleCleanupDisabledTypes();
+  void ClearUserData();
+
+  void CleanupDisabledTypes();

[tim (not reviewing), 2012/06/11 20:06:13]

nit - You can add a TODO here for me and note bug 131336

[Nicolas Zea, 2012/06/11 20:55:09]

Done.

 
   // Change status of notifications in the SyncSessionContext.
   void set_notifications_enabled(bool notifications_enabled);
 
   base::TimeDelta sessions_commit_delay() const;
 
   // DDOS avoidance function.  Calculates how long we should wait before trying
   // again after a failed sync attempt, where the last delay was |base_delay|.
   // TODO(tim): Look at URLRequestThrottlerEntryInterface.
   static base::TimeDelta GetRecommendedDelay(const base::TimeDelta& base_delay);
@@ skipping 193 matching lines @@
   JobProcessDecision DecideWhileInWaitInterval(const SyncSessionJob& job);
 
   // Saves the job for future execution. Note: It drops all the poll jobs.
   void SaveJob(const SyncSessionJob& job);
 
   // Coalesces the current job with the pending nudge.
   void InitOrCoalescePendingJob(const SyncSessionJob& job);
 
   // 'Impl' here refers to real implementation of public functions, running on
   // |thread_|.
-  void StartImpl(Mode mode, const base::Closure& callback);
   void StopImpl(const base::Closure& callback);
   void ScheduleNudgeImpl(
       const base::TimeDelta& delay,
       sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source,
       const syncable::ModelTypePayloadMap& types_with_payloads,
       bool is_canary_job, const tracked_objects::Location& nudge_location);
-  void ScheduleConfigImpl(const ModelSafeRoutingInfo& routing_info,
-      const std::vector<ModelSafeWorker*>& workers,
-      const sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source);
-  void ScheduleClearUserDataImpl();
 
   // Returns true if the client is currently in exponential backoff.
   bool IsBackingOff() const;
 
   // Helper to signal all listeners registered with |session_context_|.
   void Notify(SyncEngineEvent::EventCause cause);
 
   // Callback to change backoff state.
   void DoCanaryJob();
   void Unthrottle();
@@ skipping 76 matching lines @@
   scoped_ptr<Syncer> syncer_;
 
   sessions::SyncSessionContext *session_context_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncScheduler);
 };
 
 }  // namespace browser_sync
 
 #endif  // SYNC_ENGINE_SYNC_SCHEDULER_H_