Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: chrome/browser/shell_integration.h

Issue 10542031: Suffix Chrome's appid on user-level installs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix shell integration test Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/shell_integration.h
diff --git a/chrome/browser/shell_integration.h b/chrome/browser/shell_integration.h
index eb7d716c6e81a1cfdf6b450fbc80e300f657fee4..a6d54785bdae32a9de49aa9cf404c92978459ff0 100644
--- a/chrome/browser/shell_integration.h
+++ b/chrome/browser/shell_integration.h
@@ -123,15 +123,19 @@ class ShellIntegration {
bool is_platform_app);
#if defined(OS_WIN)
- // Generates Win7 app id for given app name and profile path. The returned app
- // id is in the format of "|app_name|[.<profile_id>]". "profile_id" is
- // appended when user override the default value.
- static string16 GetAppId(const string16& app_name,
- const FilePath& profile_path);
-
- // Generates Win7 app id for Chromium by calling GetAppId with
- // chrome::kBrowserAppID as app_name.
- static string16 GetChromiumAppId(const FilePath& profile_path);
+ // Generates an application user model ID (AppUserModelId) for a given app
+ // name and profile path. The returned app id is in the format of
+ // "|app_name|[.<profile_id>]". "profile_id" is appended when user override
+ // the default value.
+ // Note: If the app has an installation specific suffix (e.g. on user-level
+ // Chrome installs), |app_name| should already be suffixed, this method will
+ // then further suffix it with the profile id as described above.
+ static string16 GetAppModelId(const string16& app_name,
+ const FilePath& profile_path);
+
+ // Generates an application user model ID (AppUserModelId) for Chromium by
+ // calling GetAppModelId() with ShellUtil::GetAppId() as app_name.
+ static string16 GetChromiumModelId(const FilePath& profile_path);
// Returns the path to the Chromium icon. This is used to specify the icon
// to use for the taskbar group on Win 7.

Powered by Google App Engine
This is Rietveld 408576698