Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8102)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 10542031: Suffix Chrome's appid on user-level installs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase on hkcu@appname@suffix@r142136 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index 179ae95901624bf47118c8298188d269c7c40e58..5b58f3219f1e0d7547d8bbad54a5c127a0a32b85 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -533,7 +533,15 @@ bool DeleteChromeRegistrationKeys(BrowserDistribution* dist, HKEY root,
// Delete Software\Classes\Chrome (Same comment as above applies for this too)
string16 chrome_app_id(ShellUtil::kRegClasses);
chrome_app_id.push_back(FilePath::kSeparators[0]);
- chrome_app_id.append(dist->GetBrowserAppId());
+ if (browser_entry_suffix.empty()) {
+ // An unsuffixed appid used to be registered on some user-level install
+ // (dev-channel 21.0.1171.0). Make sure it gets cleaned up here.
+ // Note: this couldn't be cleaned on update as a currently running old
+ // chrome might still be using the unsuffixed appid when the registration
+ // update steps run.
+ InstallUtil::DeleteRegistryKey(root, chrome_app_id + dist->GetBaseAppId());
+ }
+ chrome_app_id.append(ShellUtil::GetAppId(dist, chrome_exe.value()));
InstallUtil::DeleteRegistryKey(root, chrome_app_id);
// Delete all Start Menu Internet registrations that refer to this Chrome.

Powered by Google App Engine
This is Rietveld 408576698