Suffix Chrome's appid on user-level installs

chrome/installer/util/shell_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares methods that are useful for integrating Chrome in
 // Windows shell. These methods are all static and currently part of
 // ShellUtil class.
 
 #ifndef CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
 #define CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
@@ skipping 224 matching lines @@
                                                const string16& chrome_exe);
 
   // Returns the application name of the program under |dist|.
   // This application name will be suffixed as is appropriate for the current
   // install.
   // This is the name that is registered with Default Programs on Windows and
   // that should thus be used to "make chrome default" and such.
   static string16 GetApplicationName(BrowserDistribution* dist,
                                      const string16& chrome_exe);
 
+  // Returns the AppUserModelId for |dist|. This identifier is unconditionally
+  // suffixed with the user id for user-level installs (in contrast to other
+  // registration entries which are suffix as described in
+  // GetCurrentInstallationSuffix() above).
+  static string16 GetChromiumModelId(BrowserDistribution* dist,

[grt (UTC plus 2), 2012/06/18 19:45:08]

Hmm.  I like GetAppId better, since |dist| might not represent a web browser
named Chromium.

[gab, 2012/06/18 21:52:43]

I did this to reflect the call sites in ShellIntegration; also given this takes
|chrome_exe| I think |dist| should only be Chrome, Chromium, or one of its other
browser variants (i.e. not Chrome Frame, etc.)

On that note I agree this is not necessarily "Chromium" so I'll change it to
GetBrowserModelId.. ok?

+                                     const string16& chrome_exe);
+
+  // Returns an AppUserModelId composed of each member of |components| separated
+  // by dots.
+  // The returned appid is guaranteed to be no longer than
+  // chrome::kMaxAppModelIdLength (some of the components might have been
+  // truncated to enforce this).
+  static string16 ConstructAppModelId(const std::vector<string16>& components);
+
   // Make Chrome the default browser. This function works by going through
   // the url protocols and file associations that are related to general
   // browsing, e.g. http, https, .html etc., and requesting to become the
   // default handler for each. If any of these fails the operation will return
   // false to indicate failure, which is consistent with the return value of
   // ShellIntegration::IsDefaultBrowser.
   //
   // In the case of failure any successful changes will be left, however no
   // more changes will be attempted.
   // TODO(benwells): Attempt to undo any changes that were successfully made.
@@ skipping 130 matching lines @@
                                    const string16& icon_path,
                                    int icon_index,
                                    uint32 options);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ShellUtil);
 };
 
 
 #endif  // CHROME_INSTALLER_UTIL_SHELL_UTIL_H_