Disable modifying extensions when in managed mode.

chrome/browser/resources/extensions/extensions.js

Index: chrome/browser/resources/extensions/extensions.js
===================================================================
--- chrome/browser/resources/extensions/extensions.js	(revision 141651)
+++ chrome/browser/resources/extensions/extensions.js	(working copy)
@@ -223,13 +223,25 @@
       });
     }
 
-    if (extensionsData.developerMode) {
+    var developer_mode = extensionsData.developerMode;

[Patrick Dubroy, 2012/06/18 12:13:01]

JS style is developerMode, not developer_mode.

+    var pageDiv = $('extension-settings');
+    if (extensionsData.managedMode) {
+      pageDiv.classList.add('showing-banner');

[Patrick Dubroy, 2012/06/18 12:13:01]

Do you need both of these classes? Can't you just show the banner whenever
managed mode is enabled?

[Pam (message me for reviews), 2012/06/18 18:26:00]

Showing-banner controls the page banner, which is part of the shared CSS and
thus isn't managed-mode-specific. And managed-mode controls the visibility of
the optional controls for each listed extension.

+      pageDiv.classList.add('managed-mode');
+      $('toggle-dev-on').disabled = true;
+      developer_mode = false;
+    } else {
+      pageDiv.classList.remove('showing-banner');
+      pageDiv.classList.remove('managed-mode');
+      $('toggle-dev-on').disabled = false;
+    }
+
+    if (developer_mode) {

[Patrick Dubroy, 2012/06/18 12:13:01]

I'd just do this:

    if (extensionsData.developerMode && !extensionsData.managedMode)

and get rid of the variable.

+      pageDiv.classList.add('dev-mode');
       $('toggle-dev-on').checked = true;
-      $('extension-settings').classList.add('dev-mode');
-      $('dev-controls').hidden = false;
     } else {
+      pageDiv.classList.remove('dev-mode');
       $('toggle-dev-on').checked = false;
-      $('extension-settings').classList.remove('dev-mode');
     }
 
     $('load-unpacked').disabled = extensionsData.loadUnpackedDisabled;