Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: chrome/browser/resources/extensions/extensions.js

Issue 10542023: Disable modifying extensions when in managed mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Improve/fix InitImpl() Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="../shared/js/cr/ui/drag_wrapper.js"></include> 5 <include src="../shared/js/cr/ui/drag_wrapper.js"></include>
6 <include src="../uber/uber_utils.js"></include> 6 <include src="../uber/uber_utils.js"></include>
7 <include src="extension_commands_overlay.js"></include> 7 <include src="extension_commands_overlay.js"></include>
8 <include src="extension_focus_manager.js"></include> 8 <include src="extension_focus_manager.js"></include>
9 <include src="extension_list.js"></include> 9 <include src="extension_list.js"></include>
10 <include src="pack_extension_overlay.js"></include> 10 <include src="pack_extension_overlay.js"></include>
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 if (a.order == b.order) { 216 if (a.order == b.order) {
217 a = a.name.toLowerCase(); 217 a = a.name.toLowerCase();
218 b = b.name.toLowerCase(); 218 b = b.name.toLowerCase();
219 return a < b ? -1 : (a > b ? 1 : 0); 219 return a < b ? -1 : (a > b ? 1 : 0);
220 } else { 220 } else {
221 return a.order < b.order ? -1 : 1; 221 return a.order < b.order ? -1 : 1;
222 } 222 }
223 }); 223 });
224 } 224 }
225 225
226 if (extensionsData.developerMode) { 226 var developer_mode = extensionsData.developerMode;
Patrick Dubroy 2012/06/18 12:13:01 JS style is developerMode, not developer_mode.
227 var pageDiv = $('extension-settings');
228 if (extensionsData.managedMode) {
229 pageDiv.classList.add('showing-banner');
Patrick Dubroy 2012/06/18 12:13:01 Do you need both of these classes? Can't you just
Pam (message me for reviews) 2012/06/18 18:26:00 Showing-banner controls the page banner, which is
230 pageDiv.classList.add('managed-mode');
231 $('toggle-dev-on').disabled = true;
232 developer_mode = false;
233 } else {
234 pageDiv.classList.remove('showing-banner');
235 pageDiv.classList.remove('managed-mode');
236 $('toggle-dev-on').disabled = false;
237 }
238
239 if (developer_mode) {
Patrick Dubroy 2012/06/18 12:13:01 I'd just do this: if (extensionsData.develope
240 pageDiv.classList.add('dev-mode');
227 $('toggle-dev-on').checked = true; 241 $('toggle-dev-on').checked = true;
228 $('extension-settings').classList.add('dev-mode');
229 $('dev-controls').hidden = false;
230 } else { 242 } else {
243 pageDiv.classList.remove('dev-mode');
231 $('toggle-dev-on').checked = false; 244 $('toggle-dev-on').checked = false;
232 $('extension-settings').classList.remove('dev-mode');
233 } 245 }
234 246
235 $('load-unpacked').disabled = extensionsData.loadUnpackedDisabled; 247 $('load-unpacked').disabled = extensionsData.loadUnpackedDisabled;
236 248
237 ExtensionsList.prototype.data_ = extensionsData; 249 ExtensionsList.prototype.data_ = extensionsData;
238 var extensionList = $('extension-settings-list'); 250 var extensionList = $('extension-settings-list');
239 ExtensionsList.decorate(extensionList); 251 ExtensionsList.decorate(extensionList);
240 } 252 }
241 253
242 // Indicate that warning |message| has occured for pack of |crx_path| and 254 // Indicate that warning |message| has occured for pack of |crx_path| and
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 return { 333 return {
322 ExtensionSettings: ExtensionSettings 334 ExtensionSettings: ExtensionSettings
323 }; 335 };
324 }); 336 });
325 337
326 var ExtensionSettings = extensions.ExtensionSettings; 338 var ExtensionSettings = extensions.ExtensionSettings;
327 339
328 window.addEventListener('load', function(e) { 340 window.addEventListener('load', function(e) {
329 ExtensionSettings.getInstance().initialize(); 341 ExtensionSettings.getInstance().initialize();
330 }); 342 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698