Disable modifying extensions when in managed mode.

chrome/browser/resources/extensions/extensions.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../shared/js/cr/ui/drag_wrapper.js"></include>
 <include src="../uber/uber_utils.js"></include>
 <include src="extension_commands_overlay.js"></include>
 <include src="extension_focus_manager.js"></include>
 <include src="extension_list.js"></include>
 <include src="pack_extension_overlay.js"></include>
@@ skipping 205 matching lines @@
         if (a.order == b.order) {
           a = a.name.toLowerCase();
           b = b.name.toLowerCase();
           return a < b ? -1 : (a > b ? 1 : 0);
         } else {
           return a.order < b.order ? -1 : 1;
         }
       });
     }
 
-    if (extensionsData.developerMode) {
+    var developer_mode = extensionsData.developerMode;

[Patrick Dubroy, 2012/06/18 12:13:01]

JS style is developerMode, not developer_mode.

+    var pageDiv = $('extension-settings');
+    if (extensionsData.managedMode) {
+      pageDiv.classList.add('showing-banner');

[Patrick Dubroy, 2012/06/18 12:13:01]

Do you need both of these classes? Can't you just show the banner whenever
managed mode is enabled?

[Pam (message me for reviews), 2012/06/18 18:26:00]

Showing-banner controls the page banner, which is part of the shared CSS and
thus isn't managed-mode-specific. And managed-mode controls the visibility of
the optional controls for each listed extension.

+      pageDiv.classList.add('managed-mode');
+      $('toggle-dev-on').disabled = true;
+      developer_mode = false;
+    } else {
+      pageDiv.classList.remove('showing-banner');
+      pageDiv.classList.remove('managed-mode');
+      $('toggle-dev-on').disabled = false;
+    }
+
+    if (developer_mode) {

[Patrick Dubroy, 2012/06/18 12:13:01]

I'd just do this:

    if (extensionsData.developerMode && !extensionsData.managedMode)

and get rid of the variable.

+      pageDiv.classList.add('dev-mode');
       $('toggle-dev-on').checked = true;
-      $('extension-settings').classList.add('dev-mode');
-      $('dev-controls').hidden = false;
     } else {
+      pageDiv.classList.remove('dev-mode');
       $('toggle-dev-on').checked = false;
-      $('extension-settings').classList.remove('dev-mode');
     }
 
     $('load-unpacked').disabled = extensionsData.loadUnpackedDisabled;
 
     ExtensionsList.prototype.data_ = extensionsData;
     var extensionList = $('extension-settings-list');
     ExtensionsList.decorate(extensionList);
   }
 
   // Indicate that warning |message| has occured for pack of |crx_path| and
@@ skipping 78 matching lines @@
   return {
     ExtensionSettings: ExtensionSettings
   };
 });
 
 var ExtensionSettings = extensions.ExtensionSettings;
 
 window.addEventListener('load', function(e) {
   ExtensionSettings.getInstance().initialize();
 });