Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: webkit/plugins/ppapi/plugin_delegate.h

Issue 10541113: Notify CloseFile from Pepper to FileSystem. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reflect review comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/plugin_delegate.h
diff --git a/webkit/plugins/ppapi/plugin_delegate.h b/webkit/plugins/ppapi/plugin_delegate.h
index 6f851907bdded5f64c17342ce3b35da16abab203..355b838971423fc4db16ebd57a0390bed3bd12e8 100644
--- a/webkit/plugins/ppapi/plugin_delegate.h
+++ b/webkit/plugins/ppapi/plugin_delegate.h
@@ -413,16 +413,29 @@ class PluginDelegate {
const WebKit::WebFileChooserParams& params,
WebKit::WebFileChooserCompletion* chooser_completion) = 0;
- // Sends an async IPC to open a file.
+ // Sends an async IPC to open a local file.
typedef base::Callback<void (base::PlatformFileError, base::PassPlatformFile)>
AsyncOpenFileCallback;
virtual bool AsyncOpenFile(const FilePath& path,
int flags,
const AsyncOpenFileCallback& callback) = 0;
+
+ // Sends an async IPC to open a file through filesystem API.
+ // When a file is successfully opened, |callback| is invoked with
+ // PLATFORM_FILE_OK, the opened file handle, and a callback function for
+ // notifying that the file is closed. When the users of this function
+ // finished using the file, it must close the file handle and then must call
yzshen1 2012/07/03 17:26:31 nit: it -> they.
kinaba 2012/07/04 04:26:22 Done.
+ // the supplied callback function.
+ typedef base::Callback<void (base::PlatformFileError)>
+ NotifyCloseFileCallback;
+ typedef base::Callback<
+ void (base::PlatformFileError,
+ base::PassPlatformFile,
+ const NotifyCloseFileCallback&)> AsyncOpenFileSystemURLCallback;
virtual bool AsyncOpenFileSystemURL(
const GURL& path,
int flags,
- const AsyncOpenFileCallback& callback) = 0;
+ const AsyncOpenFileSystemURLCallback& callback) = 0;
virtual bool OpenFileSystem(
const GURL& url,

Powered by Google App Engine
This is Rietveld 408576698