Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc

Issue 10541113: Notify CloseFile from Pepper to FileSystem. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added DLOG, DCHECK. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc b/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc
index 5d72c16fe21dc73be51a4158dd68b32054ce3e0f..1e0ad968e1417ca9fda2dfd3eea2574cdfad3d88 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc
+++ b/chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc
@@ -389,6 +389,13 @@ void GDataFileSystemProxy::OpenFile(
GetDownloadDataCallback());
}
+void GDataFileSystemProxy::NotifyCloseFile(const GURL& file_url) {
+ // TODO(kinaba,zelidrag): crbug.com/132236.
+ // Once OpenFile() for writing is implemented, we also need to implement the
+ // corresponding NotifyCloseFile for committing dirty cache.
zel 2012/06/27 00:08:03 please see how I implemented this method at: https
kinaba 2012/06/27 03:47:42 Thanks, it is the exact implementation I imagined!
+}
+
kinuko 2012/06/26 11:13:36 nit: extra empty line
kinaba 2012/06/27 03:47:42 Done.
+
void GDataFileSystemProxy::CreateSnapshotFile(
const GURL& file_url,
const FileSystemOperationInterface::SnapshotFileCallback& callback) {

Powered by Google App Engine
This is Rietveld 408576698