Notify CloseFile from Pepper to FileSystem.

webkit/plugins/ppapi/plugin_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PLUGIN_DELEGATE_H_
 #define WEBKIT_PLUGINS_PPAPI_PLUGIN_DELEGATE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 406 matching lines @@
   typedef base::Callback<void (base::PlatformFileError, base::PassPlatformFile)>
       AsyncOpenFileCallback;
   virtual bool AsyncOpenFile(const FilePath& path,
                              int flags,
                              const AsyncOpenFileCallback& callback) = 0;
   virtual bool AsyncOpenFileSystemURL(
       const GURL& path,
       int flags,
       const AsyncOpenFileCallback& callback) = 0;
 
+  // Retrieves a callback for doing clean-up task for closing filesystem URL.
+  virtual base::Callback<void (base::PlatformFileError)>

[yzshen1, 2012/06/28 20:14:17]

It seems more intuitive to have such an interface:
- Don't have a separate GetCloseFileSystemURLCallback method;
AsyncOpenFileSystemURL will take a new type of callback,
AsyncOpenFile*SystemURL*Callback.

- AsyncOpenFileSystemURLCallback has one more input parameter, which is a close
callback. This callback has remembered the corresponding plugin delegate
instance, as well as the file system URL.
If the open succeeds, the user is responsible for closing the file handle and
then call the close callback. They can easily do this by passing both of them to
base::FileUtilProxy::Close.

(Maybe it is just more intuitive to me? :))

[kinaba, 2012/06/29 09:28:33]

No reason to object. Done.

+      GetCloseFileSystemURLCallback(const GURL& path) = 0;
+
   virtual bool OpenFileSystem(
       const GURL& url,
       fileapi::FileSystemType type,
       long long size,
       fileapi::FileSystemCallbackDispatcher* dispatcher) = 0;
   virtual bool MakeDirectory(
       const GURL& path,
       bool recursive,
       fileapi::FileSystemCallbackDispatcher* dispatcher) = 0;
   virtual bool Query(const GURL& path,
@@ skipping 211 matching lines @@
   virtual webkit_glue::ClipboardClient* CreateClipboardClient() const = 0;
 
   // Returns a Device ID
   virtual std::string GetDeviceID() = 0;
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PLUGIN_DELEGATE_H_