Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 10541053: Remove Android specifc LUMP_OF_MEMORY. (Closed)

Created:
8 years, 6 months ago by benm (inactive)
Modified:
8 years, 6 months ago
Reviewers:
ulan, Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Adjust Android heap sizes. This improves performance on heavy pages by increasing max_executable_size_ and max_old_generation_size_. There is now no need for an Android specific LUMP_OF_MEMORY. Committed: https://code.google.com/p/v8/source/detail?r=11740

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/heap.cc View 1 2 3 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
benm (inactive)
8 years, 6 months ago (2012-06-07 17:47:14 UTC) #1
ulan
This would make max_old_generation_size_==700MB. On my devices Dalvik VM heap size is 256MB. What if ...
8 years, 6 months ago (2012-06-08 08:54:13 UTC) #2
ulan
8 years, 6 months ago (2012-06-08 10:32:16 UTC) #3
LGTM. Thank you, I will land it for you.

Powered by Google App Engine
This is Rietveld 408576698