Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: sync/util/cryptographer_unittest.cc

Issue 10540149: [Sync] Persist keystore key across restarts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/util/cryptographer.cc ('k') | sync/util/get_session_name.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/util/cryptographer.h" 5 #include "sync/util/cryptographer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 sync_pb::EncryptedData encrypted3; 140 sync_pb::EncryptedData encrypted3;
141 EXPECT_TRUE(cryptographer_.Encrypt(original, &encrypted3)); 141 EXPECT_TRUE(cryptographer_.Encrypt(original, &encrypted3));
142 sync_pb::EncryptedData encrypted4; 142 sync_pb::EncryptedData encrypted4;
143 EXPECT_TRUE(cryptographer_.Encrypt(original, &encrypted4)); 143 EXPECT_TRUE(cryptographer_.Encrypt(original, &encrypted4));
144 144
145 EXPECT_EQ(encrypted1.key_name(), encrypted2.key_name()); 145 EXPECT_EQ(encrypted1.key_name(), encrypted2.key_name());
146 EXPECT_NE(encrypted1.key_name(), encrypted3.key_name()); 146 EXPECT_NE(encrypted1.key_name(), encrypted3.key_name());
147 EXPECT_EQ(encrypted3.key_name(), encrypted4.key_name()); 147 EXPECT_EQ(encrypted3.key_name(), encrypted4.key_name());
148 } 148 }
149 149
150 // Ensure setting the keystore key works and doesn't modify the default nigori.
151 TEST_F(SyncCryptographerTest, SetKeystore) {
152 EXPECT_FALSE(cryptographer_.is_initialized());
153 EXPECT_FALSE(cryptographer_.HasKeystoreKey());
154
155 EXPECT_FALSE(cryptographer_.SetKeystoreKey(""));
156 EXPECT_FALSE(cryptographer_.HasKeystoreKey());
157
158 EXPECT_TRUE(cryptographer_.SetKeystoreKey("keystore_key"));
159 EXPECT_TRUE(cryptographer_.HasKeystoreKey());
160 EXPECT_FALSE(cryptographer_.is_initialized());
161 }
162
150 // Crashes, Bug 55178. 163 // Crashes, Bug 55178.
151 #if defined(OS_WIN) 164 #if defined(OS_WIN)
152 #define MAYBE_EncryptExportDecrypt DISABLED_EncryptExportDecrypt 165 #define MAYBE_EncryptExportDecrypt DISABLED_EncryptExportDecrypt
153 #else 166 #else
154 #define MAYBE_EncryptExportDecrypt EncryptExportDecrypt 167 #define MAYBE_EncryptExportDecrypt EncryptExportDecrypt
155 #endif 168 #endif
156 TEST_F(SyncCryptographerTest, MAYBE_EncryptExportDecrypt) { 169 TEST_F(SyncCryptographerTest, MAYBE_EncryptExportDecrypt) {
157 sync_pb::EncryptedData nigori; 170 sync_pb::EncryptedData nigori;
158 sync_pb::EncryptedData encrypted; 171 sync_pb::EncryptedData encrypted;
159 172
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 EXPECT_NE(static_cast<Nigori*>(NULL), unpacked.get()); 226 EXPECT_NE(static_cast<Nigori*>(NULL), unpacked.get());
214 227
215 std::string user_key, encryption_key, mac_key; 228 std::string user_key, encryption_key, mac_key;
216 ASSERT_TRUE(unpacked->ExportKeys(&user_key, &encryption_key, &mac_key)); 229 ASSERT_TRUE(unpacked->ExportKeys(&user_key, &encryption_key, &mac_key));
217 230
218 EXPECT_EQ(expected_user, user_key); 231 EXPECT_EQ(expected_user, user_key);
219 EXPECT_EQ(expected_encryption, encryption_key); 232 EXPECT_EQ(expected_encryption, encryption_key);
220 EXPECT_EQ(expected_mac, mac_key); 233 EXPECT_EQ(expected_mac, mac_key);
221 } 234 }
222 235
236 // Test that bootstrapping the keystore key works and doesn't affect the default
237 // nigori.
238 TEST_F(SyncCryptographerTest, BootstrapKeystore) {
239 std::string token;
240 cryptographer_.GetKeystoreKeyBootstrapToken(&token);
241 EXPECT_TRUE(token.empty());
242
243 cryptographer_.SetKeystoreKey("keystore_key");
244 cryptographer_.GetKeystoreKeyBootstrapToken(&token);
245 EXPECT_FALSE(token.empty());
246
247 Cryptographer cryptographer2(&encryptor_);
248 EXPECT_FALSE(cryptographer2.HasKeystoreKey());
249 cryptographer2.BootstrapKeystoreKey(token);
250 EXPECT_TRUE(cryptographer2.HasKeystoreKey());
251 EXPECT_FALSE(cryptographer2.is_initialized());
252 }
253
223 TEST_F(SyncCryptographerTest, NigoriEncryptionTypes) { 254 TEST_F(SyncCryptographerTest, NigoriEncryptionTypes) {
224 Cryptographer cryptographer2(&encryptor_); 255 Cryptographer cryptographer2(&encryptor_);
225 sync_pb::NigoriSpecifics nigori; 256 sync_pb::NigoriSpecifics nigori;
226 257
227 StrictMock<MockObserver> observer; 258 StrictMock<MockObserver> observer;
228 cryptographer_.AddObserver(&observer); 259 cryptographer_.AddObserver(&observer);
229 StrictMock<MockObserver> observer2; 260 StrictMock<MockObserver> observer2;
230 cryptographer2.AddObserver(&observer2); 261 cryptographer2.AddObserver(&observer2);
231 262
232 // Just set the sensitive types (shouldn't trigger any 263 // Just set the sensitive types (shouldn't trigger any
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 iter.Get() == BOOKMARKS) 408 iter.Get() == BOOKMARKS)
378 EXPECT_TRUE(encrypted_types.Has(iter.Get())); 409 EXPECT_TRUE(encrypted_types.Has(iter.Get()));
379 else 410 else
380 EXPECT_FALSE(encrypted_types.Has(iter.Get())); 411 EXPECT_FALSE(encrypted_types.Has(iter.Get()));
381 } 412 }
382 413
383 cryptographer_.RemoveObserver(&observer); 414 cryptographer_.RemoveObserver(&observer);
384 } 415 }
385 416
386 } // namespace syncer 417 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/util/cryptographer.cc ('k') | sync/util/get_session_name.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698