Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: sync/util/cryptographer_unittest.cc

Issue 10540149: [Sync] Persist keystore key across restarts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« sync/util/cryptographer.cc ('K') | « sync/util/cryptographer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/util/cryptographer.h" 5 #include "sync/util/cryptographer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 sync_pb::EncryptedData encrypted3; 142 sync_pb::EncryptedData encrypted3;
143 EXPECT_TRUE(cryptographer_.Encrypt(original, &encrypted3)); 143 EXPECT_TRUE(cryptographer_.Encrypt(original, &encrypted3));
144 sync_pb::EncryptedData encrypted4; 144 sync_pb::EncryptedData encrypted4;
145 EXPECT_TRUE(cryptographer_.Encrypt(original, &encrypted4)); 145 EXPECT_TRUE(cryptographer_.Encrypt(original, &encrypted4));
146 146
147 EXPECT_EQ(encrypted1.key_name(), encrypted2.key_name()); 147 EXPECT_EQ(encrypted1.key_name(), encrypted2.key_name());
148 EXPECT_NE(encrypted1.key_name(), encrypted3.key_name()); 148 EXPECT_NE(encrypted1.key_name(), encrypted3.key_name());
149 EXPECT_EQ(encrypted3.key_name(), encrypted4.key_name()); 149 EXPECT_EQ(encrypted3.key_name(), encrypted4.key_name());
150 } 150 }
151 151
152 // Ensure setting the keystore key works and doesn't modify the default nigori.
153 TEST_F(SyncCryptographerTest, SetKeystore) {
154 EXPECT_FALSE(cryptographer_.is_initialized());
155 EXPECT_FALSE(cryptographer_.HasKeystoreKey());
156
157 EXPECT_FALSE(cryptographer_.SetKeystoreKey(""));
158 EXPECT_FALSE(cryptographer_.HasKeystoreKey());
159
160 EXPECT_TRUE(cryptographer_.SetKeystoreKey("keystore_key"));
161 EXPECT_TRUE(cryptographer_.HasKeystoreKey());
162 EXPECT_FALSE(cryptographer_.is_initialized());
163 }
164
152 // Crashes, Bug 55178. 165 // Crashes, Bug 55178.
153 #if defined(OS_WIN) 166 #if defined(OS_WIN)
154 #define MAYBE_EncryptExportDecrypt DISABLED_EncryptExportDecrypt 167 #define MAYBE_EncryptExportDecrypt DISABLED_EncryptExportDecrypt
155 #else 168 #else
156 #define MAYBE_EncryptExportDecrypt EncryptExportDecrypt 169 #define MAYBE_EncryptExportDecrypt EncryptExportDecrypt
157 #endif 170 #endif
158 TEST_F(SyncCryptographerTest, MAYBE_EncryptExportDecrypt) { 171 TEST_F(SyncCryptographerTest, MAYBE_EncryptExportDecrypt) {
159 sync_pb::EncryptedData nigori; 172 sync_pb::EncryptedData nigori;
160 sync_pb::EncryptedData encrypted; 173 sync_pb::EncryptedData encrypted;
161 174
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 EXPECT_NE(static_cast<Nigori*>(NULL), unpacked.get()); 228 EXPECT_NE(static_cast<Nigori*>(NULL), unpacked.get());
216 229
217 std::string user_key, encryption_key, mac_key; 230 std::string user_key, encryption_key, mac_key;
218 ASSERT_TRUE(unpacked->ExportKeys(&user_key, &encryption_key, &mac_key)); 231 ASSERT_TRUE(unpacked->ExportKeys(&user_key, &encryption_key, &mac_key));
219 232
220 EXPECT_EQ(expected_user, user_key); 233 EXPECT_EQ(expected_user, user_key);
221 EXPECT_EQ(expected_encryption, encryption_key); 234 EXPECT_EQ(expected_encryption, encryption_key);
222 EXPECT_EQ(expected_mac, mac_key); 235 EXPECT_EQ(expected_mac, mac_key);
223 } 236 }
224 237
238 // Test that bootstrapping the keystore key works and doesn't affect the default
239 // nigori.
240 TEST_F(SyncCryptographerTest, BootstrapKeystore) {
241 std::string token;
242 cryptographer_.GetKeystoreKeyBootstrapToken(&token);
243 EXPECT_TRUE(token.empty());
244
245 cryptographer_.SetKeystoreKey("keystore_key");
246 cryptographer_.GetKeystoreKeyBootstrapToken(&token);
247 EXPECT_FALSE(token.empty());
248
249 Cryptographer cryptographer2(&encryptor_);
250 EXPECT_FALSE(cryptographer2.HasKeystoreKey());
251 cryptographer2.BootstrapKeystoreKey(token);
252 EXPECT_TRUE(cryptographer2.HasKeystoreKey());
253 EXPECT_FALSE(cryptographer2.is_initialized());
254 }
255
225 TEST_F(SyncCryptographerTest, NigoriEncryptionTypes) { 256 TEST_F(SyncCryptographerTest, NigoriEncryptionTypes) {
226 Cryptographer cryptographer2(&encryptor_); 257 Cryptographer cryptographer2(&encryptor_);
227 sync_pb::NigoriSpecifics nigori; 258 sync_pb::NigoriSpecifics nigori;
228 259
229 StrictMock<MockObserver> observer; 260 StrictMock<MockObserver> observer;
230 cryptographer_.AddObserver(&observer); 261 cryptographer_.AddObserver(&observer);
231 StrictMock<MockObserver> observer2; 262 StrictMock<MockObserver> observer2;
232 cryptographer2.AddObserver(&observer2); 263 cryptographer2.AddObserver(&observer2);
233 264
234 // Just set the sensitive types (shouldn't trigger any 265 // Just set the sensitive types (shouldn't trigger any
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 iter.Get() == syncable::BOOKMARKS) 413 iter.Get() == syncable::BOOKMARKS)
383 EXPECT_TRUE(encrypted_types.Has(iter.Get())); 414 EXPECT_TRUE(encrypted_types.Has(iter.Get()));
384 else 415 else
385 EXPECT_FALSE(encrypted_types.Has(iter.Get())); 416 EXPECT_FALSE(encrypted_types.Has(iter.Get()));
386 } 417 }
387 418
388 cryptographer_.RemoveObserver(&observer); 419 cryptographer_.RemoveObserver(&observer);
389 } 420 }
390 421
391 } // namespace browser_sync 422 } // namespace browser_sync
OLDNEW
« sync/util/cryptographer.cc ('K') | « sync/util/cryptographer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698