gdata: Convert GDataFileSystem::AddUploadFile() to asynchronous.

chrome/browser/chromeos/gdata/gdata_file_system.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_file_system.h"
 
 #include <set>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 216 matching lines @@
 // Ditto for FileOperationCallback
 void RunFileOperationCallbackHelper(
     const FileOperationCallback& callback,
     base::PlatformFileError* error) {
   DCHECK(error);
 
   if (!callback.is_null())
     callback.Run(*error);
 }
 
+// Callback for StoreToCache invoked by AddUploadedFileOnUIThread.
+void OnStoreToCacheForAddUploadedFile(
+    const base::Closure& callback,
+    base::PlatformFileError /* error */,
+    const std::string& /* resource_id */,
+    const std::string& /* md5 */) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  if (!callback.is_null())
+    callback.Run();
+}
+
+// Helper function called upon completion of AddUploadFile invoked by
+// OnTransferCompleted.
+void OnAddUploadFileCompleted(
+    const FileOperationCallback& callback,
+    base::PlatformFileError error,
+    scoped_ptr<UploadFileInfo> /* upload_file_info */){
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  if (!callback.is_null())
+    callback.Run(error);
+}
+
 // Used to implement GetCacheState.
 void RunGetCacheStateCallbackHelper(
     const GetCacheStateCallback& callback,
     GDataCache::CacheEntry* cache_entry,
     bool* success) {
   DCHECK(cache_entry);
   DCHECK(success);
   if (callback.is_null())
     return;
 
@@ skipping 897 matching lines @@
       base::Bind(&GDataFileSystem::OnTransferCompleted,
                  ui_weak_ptr_,
                  callback);
 
   service->uploader()->UploadFile(scoped_ptr<UploadFileInfo>(upload_file_info));
 }
 
 void GDataFileSystem::OnTransferCompleted(
     const FileOperationCallback& callback,
     base::PlatformFileError error,
-    UploadFileInfo* upload_file_info) {
+    scoped_ptr<UploadFileInfo> upload_file_info) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  DCHECK(upload_file_info);
+  DCHECK(upload_file_info.get());
 
   if (error == base::PLATFORM_FILE_OK && upload_file_info->entry.get()) {
-    AddUploadedFile(upload_file_info->gdata_path.DirName(),
-                    upload_file_info->entry.get(),
-                    upload_file_info->file_path,
-                    GDataCache::FILE_OPERATION_COPY);
+    const UploadFileInfo* upload_file_info_ptr = upload_file_info.get();

[achuithb, 2012/06/15 21:53:58]

Please add a comment.

[satorux1, 2012/06/15 21:59:15]

yeah, this is subtle. glad you caught this before submitting. :)

[hshi1, 2012/06/15 22:05:48]

Done.

[hshi1, 2012/06/15 22:05:48]

Yes, thanks for mentioning a similar issue before submitting... fortunately I
was able to abort this from CQ, it was down to the last test item.

On 2012/06/15 21:59:15, satorux1 wrote:

+    AddUploadedFile(upload_file_info_ptr->gdata_path.DirName(),
+                    upload_file_info_ptr->entry.get(),
+                    upload_file_info_ptr->file_path,
+                    GDataCache::FILE_OPERATION_COPY,
+                    base::Bind(&OnAddUploadFileCompleted,
+                               callback,
+                               error,
+                               base::Passed(&upload_file_info)));
+  } else if (!callback.is_null()) {
+    callback.Run(error);
   }
-  if (!callback.is_null())
-    callback.Run(error);
-
-  // In case of error upload_file_info will be deleted by the uploader.
-  if (error != base::PLATFORM_FILE_OK)
-    return;
-
-  // TODO(achuith): GDataFileSystem should not have to call DeleteUpload.
-  GDataSystemService* service =
-      GDataSystemServiceFactory::GetForProfile(profile_);
-  if (service)
-    service->uploader()->DeleteUpload(upload_file_info);
 }
 
 void GDataFileSystem::Copy(const FilePath& src_file_path,
                            const FilePath& dest_file_path,
                            const FileOperationCallback& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI) ||
          BrowserThread::CurrentlyOn(BrowserThread::IO));
   RunTaskOnUIThread(base::Bind(&GDataFileSystem::CopyOnUIThread,
                                ui_weak_ptr_,
                                src_file_path,
@@ skipping 2290 matching lines @@
     return base::PLATFORM_FILE_ERROR_NOT_FOUND;
 
   NotifyDirectoryChanged(parent_dir->GetFilePath());
   return base::PLATFORM_FILE_OK;
 }
 
 void GDataFileSystem::AddUploadedFile(
     const FilePath& virtual_dir_path,
     DocumentEntry* entry,
     const FilePath& file_content_path,
-    GDataCache::FileOperationType cache_operation) {
+    GDataCache::FileOperationType cache_operation,
+    const base::Closure& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
+  // Post a task to the same thread, rather than calling it here, as
+  // AddUploadedFile() is asynchronous.
+  base::MessageLoopProxy::current()->PostTask(
+      FROM_HERE,
+      base::Bind(&GDataFileSystem::AddUploadedFileOnUIThread,
+                 ui_weak_ptr_,
+                 virtual_dir_path,
+                 entry,
+                 file_content_path,
+                 cache_operation,
+                 callback));
+}
+
+void GDataFileSystem::AddUploadedFileOnUIThread(
+    const FilePath& virtual_dir_path,
+    DocumentEntry* entry,
+    const FilePath& file_content_path,
+    GDataCache::FileOperationType cache_operation,
+    const base::Closure& callback) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  DCHECK(!callback.is_null());
+
   if (!entry) {
     NOTREACHED();
+    callback.Run();
     return;
   }
 
   GDataEntry* dir_entry = GetGDataEntryByPath(virtual_dir_path);
-  if (!dir_entry)
+  if (!dir_entry) {
+    callback.Run();
     return;
+  }
 
   GDataDirectory* parent_dir  = dir_entry->AsGDataDirectory();
-  if (!parent_dir)
+  if (!parent_dir) {
+    callback.Run();
     return;
+  }
 
   scoped_ptr<GDataEntry> new_entry(
       GDataEntry::FromDocumentEntry(parent_dir, entry, root_.get()));
-  if (!new_entry.get())
+  if (!new_entry.get()) {
+    callback.Run();
     return;
+  }
 
   GDataFile* file = new_entry->AsGDataFile();
   DCHECK(file);
   const std::string& resource_id = file->resource_id();
   const std::string& md5 = file->file_md5();
   parent_dir->AddEntry(new_entry.release());
 
   NotifyDirectoryChanged(virtual_dir_path);
 
   cache_->StoreOnUIThread(resource_id, md5, file_content_path, cache_operation,
-                          CacheOperationCallback());
+                          base::Bind(&OnStoreToCacheForAddUploadedFile,
+                                     callback));
 }
 
 void GDataFileSystem::Observe(int type,
                               const content::NotificationSource& source,
                               const content::NotificationDetails& details) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   if (type == chrome::NOTIFICATION_PREF_CHANGED) {
     PrefService* pref_service = profile_->GetPrefs();
     std::string* pref_name = content::Details<std::string>(details).ptr();
@@ skipping 250 matching lines @@
     base::PlatformFileError error,
     const std::string& resource_id,
     const std::string& md5) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   if (!callback.is_null())
     callback.Run(error);
 }
 
 }  // namespace gdata