gdata: Convert GDataFileSystem::AddUploadFile() to asynchronous.

chrome/browser/chromeos/gdata/gdata_uploader.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_UPLOADER_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_UPLOADER_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 25 matching lines @@
   // Uploads a file specified by |upload_file_info|. Transfers ownership.
   // Returns the upload_id.
   int UploadFile(scoped_ptr<UploadFileInfo> upload_file_info);
 
   // Updates attributes of streaming upload.
   void UpdateUpload(int upload_id, content::DownloadItem* download);
 
   // Returns the count of bytes confirmed as uploaded so far.
   int64 GetUploadedBytes(int upload_id) const;
 
-  // TODO(achuith): Make this private.
-  // Destroys |upload_file_info|.
-  void DeleteUpload(UploadFileInfo* upload_file_info);
-
  private:
   // Lookup UploadFileInfo* in pending_uploads_.
   UploadFileInfo* GetUploadFileInfo(int upload_id) const;
 
   // Open the file.
   void OpenFile(UploadFileInfo* upload_file_info);
 
   // net::FileStream::Open completion callback. The result of the file
   // open operation is passed as |result|.
   void OpenCompletionCallback(int upload_id, int result);
@@ skipping 13 matching lines @@
 
   // DocumentsService callback for ResumeUpload.
   void OnResumeUploadResponseReceived(int upload_id,
                                       const ResumeUploadResponse& response,
                                       scoped_ptr<DocumentEntry> entry);
 
   // When upload completes, move the file into the gdata cache.
   void MoveFileToCache(UploadFileInfo* upload_file_info);
 
   // Handle failed uploads.
   void UploadFailed(UploadFileInfo* upload_file_info,

[achuithb, 2012/06/14 22:27:18]

Can we use a scoped_ptr here too?

[hshi1, 2012/06/15 00:16:28]

Done.

                     base::PlatformFileError error);
 
+  // Removes |upload_id| from UploadFileInfoMap |pending_uploads_|.
+  // Note that this does not delete the UploadFileInfo object itself,
+  // because it may still be in use by an asynchronous function.
+  void RemoveUpload(int upload_id);
+
+  // Helper function to delete the UploadFileInfo object after completion
+  // of AddUploadedFile.
+  void OnAddUploadFileComplete(UploadFileInfo* upload_file_info);

[achuithb, 2012/06/14 22:27:18]

Why does this need to be a member function? I think it should be in anonymous
scope.

Also, can we have the argument be scoped_ptr instead?

[hshi1, 2012/06/15 00:16:28]

Done.

+
   // Pointers to GDataFileSystem and DocumentsServiceInterface objects owned by
   // GDataSystemService. The lifetime of these two objects is guaranteed to
   // exceed that of the GDataUploader instance.
   GDataFileSystem* file_system_;
   DocumentsServiceInterface* documents_service_;
 
   int next_upload_id_;  // id counter.
 
   typedef std::map<int, UploadFileInfo*> UploadFileInfoMap;
   UploadFileInfoMap pending_uploads_;
 
   // Factory for various callbacks.
   base::WeakPtrFactory<GDataUploader> uploader_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GDataUploader);
 };
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_UPLOADER_H_