Issue 10539159: Additional fix for issue 2155

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10539159: Additional fix for issue 2155 (Closed)

Created:
8 years, 6 months ago by Brian Wilkerson

Modified:
8 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Additional fix for issue 2155 Committed: https://code.google.com/p/dart/source/detail?r=8683

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -5 lines)			Patch
	M	compiler/java/com/google/dart/compiler/resolver/ClassScope.java	View		3 chunks	+12 lines, -4 lines	0 comments	Download
	M	compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

http://codereview.chromium.org/10539159/diff/1/compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java File compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java (right): http://codereview.chromium.org/10539159/diff/1/compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java#newcode81 compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java:81: "class c extends B {}")); Do you really want ...

8 years, 6 months ago (2012-06-14 17:22:35 UTC) #2

Brian Wilkerson

8 years, 6 months ago (2012-06-14 18:22:15 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 10539159: Additional fix for issue 2155 (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages