lib/compiler/implementation/compiler.dart - Issue 10539156: Track fields which are known to be always set to integer constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/compiler.dart

Issue 10539156: Track fields which are known to be always set to integer constants (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed second round of comments Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/compiler.dart

diff --git a/lib/compiler/implementation/compiler.dart b/lib/compiler/implementation/compiler.dart

index d7cf15c482e4fa0d7e3a0f64656d9f14823bf99b..57d46acb327416b706de0e6f895f24eec0162ff0 100644

--- a/lib/compiler/implementation/compiler.dart

+++ b/lib/compiler/implementation/compiler.dart

@@ -463,10 +463,11 @@ class Compiler implements DiagnosticListener {

assert(phase == PHASE_RECOMPILING);

while (!world.recompilationCandidates.isEmpty()) {

WorkItem work = world.recompilationCandidates.next();

+ String oldCode = world.universe.generatedCode[work.element];

world.universe.generatedCode.remove(work.element);

- var oldCode = world.universe.generatedCode[work.element];

+ world.universe.generatedBailoutCode.remove(work.element);

withCurrentElement(work.element, () => work.run(this, world));

- var newCode = world.universe.generatedCode[work.element];

+ String newCode = world.universe.generatedCode[work.element];

if (REPORT_PASS2_OPTIMIZATIONS && newCode != oldCode) {

log("Pass 2 optimization:");

log("Before:\n$oldCode");

« no previous file with comments | « no previous file | lib/compiler/implementation/enqueue.dart » ('j') | no next file with comments »