Issue 10539110: Add negative lookups to polymorphic loads in Crankshaft.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10539110: Add negative lookups to polymorphic loads in Crankshaft. (Closed)

Created:
8 years, 6 months ago by Erik Corry

Modified:
8 years, 6 months ago

Reviewers:
Florian Schneider, fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Add negative lookups to polymorphic loads in Crankshaft. Committed: http://code.google.com/p/v8/source/detail?r=11780

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+187 lines, -41 lines)			Patch
M	src/arm/lithium-codegen-arm.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	4 chunks	+30 lines, -10 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	3 chunks	+50 lines, -7 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	3 chunks	+41 lines, -9 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	3 chunks	+41 lines, -9 lines	0 comments	Download
M	test/mjsunit/elements-transition-hoisting.js	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Florian Schneider

8 years, 6 months ago (2012-06-12 15:22:22 UTC) #2

LGTM.

Suggestion for a future improvement: also support monomorphic negative lookups
in optimized code.