NetLogEventParameter to Callback refactoring 1,

net/base/x509_certificate_net_log_param.h

Index: net/base/x509_certificate_net_log_param.h
===================================================================
--- net/base/x509_certificate_net_log_param.h	(revision 141407)
+++ net/base/x509_certificate_net_log_param.h	(working copy)
@@ -6,32 +6,19 @@
 #define NET_BASE_X509_CERT_NET_LOG_PARAM_H_
 #pragma once
 
-#include <string>
-#include <vector>
-
-#include "base/compiler_specific.h"
+#include "base/memory/ref_counted.h"
 #include "net/base/net_log.h"
 
 namespace net {
 
 class X509Certificate;
 
-// NetLog parameter to describe an X509Certificate.
-// Note: These parameters are memory intensive, due to PEM-encoding each
-// certificate, thus should only be used when logging at NetLog::LOG_ALL.

[mmenke, 2012/06/11 22:24:36]

Since we weren't actually doing this, I went ahead and removed the comment.

-class X509CertificateNetLogParam : public NetLog::EventParameters {
- public:
-  explicit X509CertificateNetLogParam(X509Certificate* certificate);
+// Creates NetLog parameter to describe an X509Certificate.
+// These parameters are memory intensive, due to PEM-encoding each certificate.

[mmenke, 2012/06/11 22:24:36]

I kept this file because of the frequency of X509Certificate's  use in files
that don't include any other net/ files.  I'm happy to move the code into
x509_certificate.cc, if you disagree.

[eroman, 2012/06/11 23:42:25]

I'm happy keeping things in place during refactor.
If we want to shuffle things around or change filenames, can do as a follow-up
step.

+base::Value* NetLogX509CertificateNetLogCallback(

[eroman, 2012/06/11 23:42:25]

nit: The naming include NetLog twice, seems redundant.

[mmenke, 2012/06/12 00:42:19]

You sure?  I was thinking about adding it a 3rd time.  Fixed.

+    scoped_refptr<const X509Certificate> certificate,
+    NetLog::LogLevel log_level);
 
-  virtual base::Value* ToValue() const OVERRIDE;
-
- protected:
-  virtual ~X509CertificateNetLogParam();
-
- private:
-  std::vector<std::string> encoded_chain_;
-};
-
 }  // namespace net
 
 #endif  // NET_BASE_X509_CERT_NET_LOG_PARAM_H_