NetLogEventParameter to Callback refactoring 1,

net/base/address_list.h

Index: net/base/address_list.h
===================================================================
--- net/base/address_list.h	(revision 141407)
+++ net/base/address_list.h	(working copy)
@@ -13,10 +13,15 @@
 #include "base/compiler_specific.h"
 #include "net/base/ip_endpoint.h"
 #include "net/base/net_export.h"
+#include "net/base/net_log.h"
 #include "net/base/net_util.h"
 
 struct addrinfo;
 
+namespace base {
+class Value;

[eroman, 2012/06/11 23:42:25]

I believe net_log.h already declares this.

[mmenke, 2012/06/12 00:42:19]

Done.

+}
+
 namespace net {
 
 class NET_EXPORT AddressList
@@ -50,6 +55,9 @@
   // Sets canonical name to the literal of the first IP address on the list.
   void SetDefaultCanonicalName();
 
+  // Creates a Value for use with the NetLog containing the address list.
+  base::Value* NetLogCallback(NetLog::LogLevel log_level) const;

[eroman, 2012/06/11 23:42:25]

Given the usecases of this, might consider making it like:

Callback CreateNetlogParamsCallback();

To avoid all the callers doing the Bind stuff.

[mmenke, 2012/06/12 00:42:19]

Done, though used "CreateNetLogCallback" instead.  Decided early that
NetLogParamsCallback was too long to append everywhere, so used NetLogCallback
instead.

+
   // Exposed methods from std::vector.
   using std::vector<IPEndPoint>::size;
   using std::vector<IPEndPoint>::empty;