Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1684)

Unified Diff: net/base/file_stream_net_log_parameters.cc

Issue 10539094: NetLogEventParameter to Callback refactoring 1, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove unneeded line Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/file_stream_net_log_parameters.cc
===================================================================
--- net/base/file_stream_net_log_parameters.cc (revision 141407)
+++ net/base/file_stream_net_log_parameters.cc (working copy)
@@ -8,19 +8,16 @@
namespace net {
-FileStreamErrorParameters::FileStreamErrorParameters(
- const std::string& operation, int os_error, net::Error net_error)
- : operation_(operation), os_error_(os_error), net_error_(net_error) {
-}
-
-FileStreamErrorParameters::~FileStreamErrorParameters() {}
-
-Value* FileStreamErrorParameters::ToValue() const {
+base::Value* NetLogFileStreamErrorCallback(
+ FileErrorSource source,
+ int os_error,
+ net::Error net_error,
+ NetLog::LogLevel /* log_level */) {
DictionaryValue* dict = new DictionaryValue();
- dict->SetString("operation", operation_);
- dict->SetInteger("os_error", os_error_);
- dict->SetInteger("net_error", net_error_);
+ dict->SetString("operation", GetFileErrorSourceName(source));
+ dict->SetInteger("os_error", os_error);
+ dict->SetInteger("net_error", net_error);
return dict;
}

Powered by Google App Engine
This is Rietveld 408576698