net/udp/udp_data_transfer_param.h - Issue 10539094: NetLogEventParameter to Callback refactoring 1,

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/udp/udp_data_transfer_param.h

Issue 10539094: NetLogEventParameter to Callback refactoring 1, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Add comment Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_UDP_UDP_DATA_TRANSFER_PARAM_H_	5 #ifndef NET_UDP_UDP_DATA_TRANSFER_PARAM_H_

6 #define NET_UDP_UDP_DATA_TRANSFER_PARAM_H_	6 #define NET_UDP_UDP_DATA_TRANSFER_PARAM_H_

7 #pragma once	7 #pragma once

8	8

9 #include <string>	9 #include <string>

10	10

(...skipping 23 matching lines...) Expand all Loading...
34 virtual ~UDPDataTransferNetLogParam();	34 virtual ~UDPDataTransferNetLogParam();

35	35

36 private:	36 private:

37 const int byte_count_;	37 const int byte_count_;

38 const std::string hex_encoded_bytes_;	38 const std::string hex_encoded_bytes_;

39 scoped_ptr<IPEndPoint> address_;	39 scoped_ptr<IPEndPoint> address_;

40 };	40 };

41	41

42 } // namespace net	42 } // namespace net

43	43

44 #endif // NET_BASE_ADDRESS_LIST_NET_LOG_PARAM_H_	44 #endif // NET_UDP_UDP_DATA_TRANSFER_PARAM_H_
	eroman 2012/06/12 05:17:26 Were any changes planned to this file as part of t Were any changes planned to this file as part of this CL? Fixing just this line is certainly fine by me, just want to check. mmenke 2012/06/12 14:52:36 Nope. Noticed it when looking for uses of address Show quoted text On 2012/06/12 05:17:26, eroman wrote: > Were any changes planned to this file as part of this CL? > Fixing just this line is certainly fine by me, just want to check. Nope. Noticed it when looking for uses of address list params. Included it in this CL rather than in a future CL just to make sure I wouldn't forget about it.
OLD	NEW

« net/socket/tcp_client_socket_win.cc ('K') | « net/socket/tcp_client_socket_win.cc ('k') | net/udp/udp_socket_libevent.h » ('j') | net/udp/udp_socket_win.cc » ('J')