Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10539042: Recognize nested logical operations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/codegen_helpers.dart » ('j') | lib/compiler/implementation/ssa/codegen_helpers.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
===================================================================
--- lib/compiler/implementation/ssa/codegen.dart (revision 8378)
+++ lib/compiler/implementation/ssa/codegen.dart (working copy)
@@ -1724,10 +1724,10 @@
}
visitPhi(HPhi node) {
- HBasicBlock ifBlock = node.block.predecessors[0].predecessors[0];
// This method is only called for phis that are generated at use
// site. A phi can be generated at use site only if it is the
// result of a logical operation.
+ HBasicBlock ifBlock = node.block.dominator;
assert(logicalOperations.contains(ifBlock.last));
HInstruction input = ifBlock.last.inputs[0];
if (input.isConstantFalse()) {
« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/codegen_helpers.dart » ('j') | lib/compiler/implementation/ssa/codegen_helpers.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698