Issue 10538099: Revert 141573 - Update use of OTR avatars for touch. We now select

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10538099: Revert 141573 - Update use of OTR avatars for touch. We now select (Closed)

Created:
8 years, 6 months ago by cpu_(ooo_6.6-7.5)

Modified:
8 years, 6 months ago

Reviewers:
Jói

CC:
chromium-reviews, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 141573 - Update use of OTR avatars for touch. We now select IDR_OTR_ICON_FULLSCREEN when in touch layout and either fullscreen or running in Metro. BUG=131698 Review URL: https://chromiumcodereview.appspot.com/10538082 TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141598

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -24 lines)			Patch
M	chrome/app/theme/theme_resources_2x.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/app/theme/theme_resources_standard.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/app/theme/theme_resources_touch_1x.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/app/theme/theme_resources_touch_2x.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	2 chunks	+1 line, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

broke aura build http://build.chromium.org/p/chromium/builders/Win%20Aura/builds/14772/steps/compile/logs/stdio

8 years, 6 months ago (2012-06-12 02:19:49 UTC) #3

Jói

8 years, 6 months ago (2012-06-12 12:39:47 UTC) #4

Thanks for reverting Carlos.

On Tue, Jun 12, 2012 at 2:19 AM,  <cpu@chromium.org> wrote:
> broke aura build
>
>
http://build.chromium.org/p/chromium/builders/Win%20Aura/builds/14772/steps/c...
>
>
> http://codereview.chromium.org/10538099/

Expand Messages | Collapse Messages