[Chromoting] Make ChromotingHost's dependency on libjingle injected, instead of hard-coded.

remoting/host/chromoting_host_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop_proxy.h"
 #include "remoting/jingle_glue/mock_objects.h"
 #include "remoting/host/capturer_fake.h"
 #include "remoting/host/chromoting_host.h"
@@ skipping 74 matching lines @@
         .Times(AnyNumber());
     EXPECT_CALL(context_, ui_message_loop())
         .Times(AnyNumber());
 
     scoped_ptr<Capturer> capturer(new CapturerFake());
     scoped_ptr<EventExecutor> event_executor(new MockEventExecutor());
     desktop_environment_ = DesktopEnvironment::CreateFake(
         &context_,
         capturer.Pass(),
         event_executor.Pass());
+    scoped_ptr<protocol::SessionManager> session_manager(
+        new protocol::MockSessionManager());
 
     host_ = new ChromotingHost(
         &context_, &signal_strategy_, desktop_environment_.get(),
-        NetworkSettings());
+        session_manager.Pass());

[Wez, 2012/06/12 21:20:10]

nit: Pass in the new mock object directly, rather than via a local var?

[simonmorris, 2012/06/13 16:26:33]

In a subsequent CL, the mock object will have expectations set, so it'll need to
be a local variable. The change will be easier to read if I keep it this way for
now.

 
     disconnect_window_ = new MockDisconnectWindow();
     continue_window_ = new MockContinueWindow();
     local_input_monitor_ = new MockLocalInputMonitor();
     it2me_host_user_interface_.reset(new It2MeHostUserInterface(&context_));
     it2me_host_user_interface_->StartForTest(
         host_,
         base::Bind(&ChromotingHost::Shutdown, host_, base::Closure()),
         scoped_ptr<DisconnectWindow>(disconnect_window_),
         scoped_ptr<ContinueWindow>(continue_window_),
@@ skipping 264 matching lines @@
   EXPECT_CALL(*connection_, Disconnect())
       .RetiresOnSaturation();
   EXPECT_CALL(*connection2_, Disconnect())
       .RetiresOnSaturation();
 
   SimulateClientConnection(0, true);
   message_loop_.Run();
 }
 
 }  // namespace remoting