[Chromoting] Make ChromotingHost's dependency on libjingle injected, instead of hard-coded.

remoting/host/jingle_session_manager_factory.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_JINGLE_SESSION_MANAGER_FACTORY_H_
+#define REMOTING_HOST_JINGLE_SESSION_MANAGER_FACTORY_H_
+
+#include "remoting/host/session_manager_factory.h"
+
+namespace remoting {
+
+struct NetworkSettings;
+
+class JingleSessionManagerFactory : public SessionManagerFactory {

[Wez, 2012/06/11 22:17:06]

Add a brief comment explaining what this factory makes.

[simonmorris, 2012/06/11 23:08:59]

Done.

+ public:
+  JingleSessionManagerFactory();
+  virtual ~JingleSessionManagerFactory() OVERRIDE;

[Wez, 2012/06/11 22:17:06]

You don't need OVERRIDE on dtors.

[simonmorris, 2012/06/11 23:08:59]

Done.

+
+  virtual scoped_ptr<protocol::SessionManager> MakeSessionManager(

[Wez, 2012/06/11 22:17:06]

nit: CreateSessionManager is more in keeping with *Factory method naming
elsewhere in remoting/

[simonmorris, 2012/06/11 23:08:59]

Done.

+      const NetworkSettings& network_settings,
+      const scoped_refptr<net::URLRequestContextGetter>&
+          url_request_context_getter) OVERRIDE;

[Wez, 2012/06/11 22:17:06]

You're missing the disallow-copy-and-assign macro here.

[simonmorris, 2012/06/11 23:08:59]

Done.

+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_HOST_JINGLE_SESSION_MANAGER_FACTORY_H_