[Chromoting] Make ChromotingHost's dependency on libjingle injected, instead of hard-coded.

remoting/host/jingle_session_manager_factory.cc

+#include "remoting/host/jingle_session_manager_factory.h"

[Wez, 2012/06/11 22:17:06]

You're missing a Copyright header.

[simonmorris, 2012/06/11 23:08:59]

Done.

+
+#include "net/url_request/url_request_context_getter.h"
+#include "remoting/host/host_port_allocator.h"
+#include "remoting/host/network_settings.h"
+#include "remoting/protocol/libjingle_transport_factory.h"
+#include "remoting/protocol/jingle_session_manager.h"
+
+namespace remoting {
+
+JingleSessionManagerFactory::JingleSessionManagerFactory() {
+}
+
+JingleSessionManagerFactory::~JingleSessionManagerFactory() {
+}
+
+scoped_ptr<protocol::SessionManager>
+JingleSessionManagerFactory::MakeSessionManager(
+    const NetworkSettings& network_settings,
+    const scoped_refptr<net::URLRequestContextGetter>&
+        url_request_context_getter) {
+  // Create port allocator and transport factory.

[Wez, 2012/06/11 22:17:06]

nit: Suggest "Create a cricket::PortAllocator that uses Chrome's network stack"?

[simonmorris, 2012/06/11 23:08:59]

Done.

+  scoped_ptr<HostPortAllocator> port_allocator(
+      HostPortAllocator::Create(url_request_context_getter,
+                                network_settings));
+
+  bool incoming_only = network_settings.nat_traversal_mode ==

[Wez, 2012/06/11 22:17:06]

nit: Suggest comment "Create a libjingle TransportFactory implementation, using
the Chrome-based PortAllocator."

[simonmorris, 2012/06/11 23:08:59]

Done.

+      NetworkSettings::NAT_TRAVERSAL_DISABLED;
+
+  scoped_ptr<protocol::TransportFactory> transport_factory(
+      new protocol::LibjingleTransportFactory(
+          port_allocator.PassAs<cricket::HttpPortAllocatorBase>(),
+          incoming_only));
+
+  // Create and session manager.

[Wez, 2012/06/11 22:17:06]

nit: Suggest "Create a Jingle-protocol SessionManager that uses the libjingle
TransportFactory."

[simonmorris, 2012/06/11 23:08:59]

Done.

+  bool fetch_stun_relay_info = network_settings.nat_traversal_mode ==
+      NetworkSettings::NAT_TRAVERSAL_ENABLED;
+  scoped_ptr<protocol::JingleSessionManager> session_manager(
+      new protocol::JingleSessionManager(
+          transport_factory.Pass(), fetch_stun_relay_info));
+  return session_manager.PassAs<protocol::SessionManager>();
+}
+
+} // namespace remoting