Update use of OTR avatars for touch. We now select

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 500 matching lines @@
   return browser_->GetSelectedWebContents();
 }
 
 TabContentsWrapper* BrowserView::GetSelectedTabContentsWrapper() const {
   return browser_->GetSelectedTabContentsWrapper();
 }
 
 gfx::ImageSkia BrowserView::GetOTRAvatarIcon() const {
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   const gfx::ImageSkia* otr_avatar =
-      rb.GetNativeImageNamed(IDR_OTR_ICON).ToImageSkia();
+      rb.GetNativeImageNamed(GetOtrIconResourceID()).ToImageSkia();
   return *otr_avatar;
 }
 
 bool BrowserView::IsPositionInWindowCaption(const gfx::Point& point) {
   return GetBrowserViewLayout()->IsPositionInWindowCaption(point);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserView, BrowserWindow implementation:
 
@@ skipping 1240 matching lines @@
     sender->child_at(i)->InvalidateLayout();
   SchedulePaint();
   Layout();
   return false;
 }
 
 void BrowserView::OnSysColorChange() {
   browser::MaybeShowInvertBubbleView(browser_->profile(), contents_);
 }
 
+int BrowserView::GetOtrIconResourceID() const {

[benrg, 2012/06/11 20:35:45]

I asked glen@ and he says this is correct.

Nit: you could save a line by dropping the variable and using three return
statements.

[Jói, 2012/06/11 22:53:42]

Thanks for checking.

Re the extra line:  I prefer to avoid multiple returns out of functions if it's
easy.

+  int otr_resource_id = IDR_OTR_ICON;
+  if (ui::GetDisplayLayout() == ui::LAYOUT_TOUCH) {
+    if (IsFullscreen())
+      otr_resource_id = IDR_OTR_ICON_FULLSCREEN;
+#if defined(OS_WIN)
+    if (base::win::GetMetroModule() != NULL)
+      otr_resource_id = IDR_OTR_ICON_FULLSCREEN;
+#endif
+  }
+
+  return otr_resource_id;
+}
+
 views::LayoutManager* BrowserView::CreateLayoutManager() const {
   return new BrowserViewLayout;
 }
 
 ToolbarView* BrowserView::CreateToolbar() const {
   return new ToolbarView(browser_.get());
 }
 
 void BrowserView::Init() {
   GetWidget()->AddObserver(this);
@@ skipping 637 matching lines @@
                                        this,
                                        web_contents->GetRenderViewHost(),
                                        password_generator,
                                        browser_.get(),
                                        wrapper->password_manager());
 
   views::BubbleDelegateView::CreateBubble(bubble);
   bubble->SetAlignment(views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE);
   bubble->Show();
 }