Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2813)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system.h

Issue 10538071: gdata: Convert FindEntryByResourceIdSync() to asynchronous. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_file_system.h
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system.h b/chrome/browser/chromeos/gdata/gdata_file_system.h
index b8daad4991f39ab978cc30e74ad6254bb3a74722..df2d03d2a35846d6f1d48c158a0fa223a898eca3 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system.h
+++ b/chrome/browser/chromeos/gdata/gdata_file_system.h
@@ -17,7 +17,6 @@
#include "base/timer.h"
#include "base/synchronization/lock.h"
#include "base/threading/sequenced_worker_pool.h"
-#include "chrome/browser/chromeos/gdata/find_entry_callback.h"
#include "chrome/browser/chromeos/gdata/gdata_cache.h"
#include "chrome/browser/chromeos/gdata/gdata_files.h"
#include "chrome/browser/prefs/pref_change_registrar.h"
@@ -183,13 +182,12 @@ class GDataFileSystemInterface {
virtual void Authenticate(const AuthStatusCallback& callback) = 0;
// Finds file info by using |resource_id|. This call does not initiate
- // content refreshing and will invoke one of |callback| methods directly as
- // it executes.
+ // content refreshing.
//
- // Can be called from UI/IO thread. |callback| is run on the calling thread
- // synchronously.
- virtual void FindEntryByResourceIdSync(const std::string& resource_id,
- const FindEntryCallback& callback) = 0;
+ // Can be called from UI/IO thread. |callback| is run on the calling thread.
+ virtual void FindEntryByResourceIdAsync(
hashimoto 2012/06/11 09:44:34 nit: Just 'FindEntryByResourceId'?
hshi1 2012/06/11 17:48:53 Done. Removed the suffix "Async" from all occurenc
+ const std::string& resource_id,
+ const FindEntryCallback& callback) = 0;
// Initiates transfer of |remote_src_file_path| to |local_dest_file_path|.
// |remote_src_file_path| is the virtual source path on the gdata file system.
@@ -434,7 +432,7 @@ class GDataFileSystem : public GDataFileSystemInterface,
virtual void StopUpdates() OVERRIDE;
virtual void CheckForUpdates() OVERRIDE;
virtual void Authenticate(const AuthStatusCallback& callback) OVERRIDE;
- virtual void FindEntryByResourceIdSync(
+ virtual void FindEntryByResourceIdAsync(
const std::string& resource_id,
const FindEntryCallback& callback) OVERRIDE;
virtual void SearchAsync(const std::string& search_query,
@@ -1448,6 +1446,9 @@ class GDataFileSystem : public GDataFileSystemInterface,
void GetFileInfoByPathAsyncOnUIThread(
const FilePath& file_path,
const GetFileInfoCallback& callback);
+ void FindEntryByResourceIdAsyncOnUIThread(
+ const std::string& resource_id,
+ const FindEntryCallback& callback);
void ReadDirectoryByPathAsyncOnUIThread(
const FilePath& file_path,
const ReadDirectoryCallback& callback);

Powered by Google App Engine
This is Rietveld 408576698