gdata: Convert FindEntryByResourceIdSync() to asynchronous.

chrome/browser/chromeos/gdata/gdata_files.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_
 #pragma once
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/singleton.h"
 #include "base/memory/weak_ptr.h"
 #include "base/platform_file.h"
 #include "base/synchronization/lock.h"
-#include "chrome/browser/chromeos/gdata/find_entry_callback.h"
 #include "chrome/browser/chromeos/gdata/gdata_params.h"
 #include "chrome/browser/chromeos/gdata/gdata_parser.h"
 #include "chrome/browser/chromeos/gdata/gdata_uploader.h"
 #include "chrome/browser/profiles/profile_keyed_service.h"
 #include "chrome/browser/profiles/profile_keyed_service_factory.h"
 
 namespace gdata {
 
+class GDataEntry;
 class GDataFile;
 class GDataDirectory;
 class GDataRootDirectory;
 
 class GDataEntryProto;
 class GDataFileProto;
 class GDataDirectoryProto;
 class GDataRootDirectoryProto;
 class PlatformFileInfoProto;
 
@@ skipping 18 matching lines @@
 };
 
 // The root directory name used for the Google Drive file system tree. The
 // name is used in URLs for the file manager, hence user-visible.
 const FilePath::CharType kGDataRootDirectory[] = FILE_PATH_LITERAL("drive");
 
 // The resource ID for the root directory is defined in the spec:
 // https://developers.google.com/google-apps/documents-list/
 const char kGDataRootDirectoryResourceId[] = "folder:root";
 
+// Used to get result of file search.
+// If |error| is not PLATFORM_FILE_OK, |entry| is set to NULL.
+typedef base::Callback<void(base::PlatformFileError error, GDataEntry* entry)>
+    FindEntryCallback;
+
+// Callback used to find a directory element for file system updates.
+void ReadOnlyFindEntryCallback(GDataEntry** out,

[hashimoto, 2012/06/11 09:44:34]

This function looks only used by GDataFileSystem::GetGDataEntryPath and
GDataFileSystemTest::FindEntry (and the two are looking almost same)
Can you make this function only visible from within gdata_file_system.cc?
(This can be postponed to a later patch)

[hshi1, 2012/06/11 17:48:53]

I'm moving this to gdata_file_system.cc, but it needs to be visible to
gdata_file_system_unittest.cc also.

[achuithb, 2012/06/11 20:46:37]

I'm not sure why you got rid of find_entry_callback.h/.cc?

[hshi1, 2012/06/11 20:58:51]

IMHO the definition of FindEntryCallback type and the ReadOnlyFindEntryCallback
function are too simple to deserve their own header and .cc files, plus it seems
unlikely that these two files would be expanded much further.

[achuithb, 2012/06/11 21:48:41]

Yes, but the new locations for FindEntryCallback and ReadOnlyFileEntryCallback
seem pretty random. FindEntryCallback is used both in gdata_file_system.h and
gdata_files.h, right? gdata_files.* is not as bad as gdata_file_system.* but
it's also big and doesn't need to get bigger with unrelated items. How about
moving it to gdata_params.h? 

[achuithb, 2012/06/12 07:59:47]

This didn't get addressed. gdata_params.h was designed to be a light-weight
place to put typedefs such as this, so you wouldn't need to include
gdata_files.h to get the definition of FindEntryCallback.

+                               base::PlatformFileError error,
+                               GDataEntry* entry);
+
 // Base class for representing files and directories in gdata virtual file
 // system.
 class GDataEntry {
  public:
   explicit GDataEntry(GDataDirectory* parent, GDataRootDirectory* root);
   virtual ~GDataEntry();
 
   virtual GDataFile* AsGDataFile();
   virtual GDataDirectory* AsGDataDirectory();
   virtual GDataRootDirectory* AsGDataRootDirectory();
@@ skipping 347 matching lines @@
   base::Time last_serialized_;
   int largest_changestamp_;
   size_t serialized_size_;
 
   DISALLOW_COPY_AND_ASSIGN(GDataRootDirectory);
 };
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_