Adds AudioDevice factory for all audio clients in Chrome

content/renderer/media/audio_device.h

Index: content/renderer/media/audio_device.h
diff --git a/content/renderer/media/audio_device.h b/content/renderer/media/audio_device.h
index 74b28d33d8558d2a8ed97f03f7ff0d5ecc6a23d3..5e3519da74ffcdd5518549979789da702e6f3f82 100644
--- a/content/renderer/media/audio_device.h
+++ b/content/renderer/media/audio_device.h
@@ -76,6 +76,8 @@
 #include "media/audio/audio_parameters.h"
 #include "media/base/audio_renderer_sink.h"
 
+class AudioMessageFilter;

[Chris Rogers, 2012/06/26 19:05:15]

It seems like you can probably just revert all the changes in this file since
you've now removed the AudioMessageFilter constructor.

[henrika (OOO until Aug 14), 2012/06/26 20:28:51]

To me the existing change still makes sense. It feels odd to have a contract
where Initialize() can be optional. Agree?

[scherkus (not reviewing), 2012/06/26 23:34:30]

If no one is using the 2-arg AD() ctor I don't see why we should keep it in -- I
agree w/ henrika@ that optional Initialize() smells a bit funny

[scherkus (not reviewing), 2012/06/26 23:34:30]

nit: this fwd decl can be removed as we #include a_m_f.h

[henrika (OOO until Aug 14), 2012/06/27 08:23:16]

Done.

[henrika (OOO until Aug 14), 2012/06/27 08:23:16]

Done.

[henrika (OOO until Aug 14), 2012/06/27 08:23:16]

Done.

+
 namespace media {
 class AudioParameters;
 }
@@ -87,11 +89,9 @@ class CONTENT_EXPORT AudioDevice
  public:
   // Methods called on main render thread -------------------------------------
 
-  // Minimal constructor where Initialize() must be called later.
+  // Minimal constructors where Initialize() must be called later.

[scherkus (not reviewing), 2012/06/26 23:34:30]

If we're going w/ the single ctor then I'd rephrase this to say "Creates an
uninitialized AudioDevice. Clients must call Initialize() before using." or
something like that

[henrika (OOO until Aug 14), 2012/06/27 08:23:16]

Thanks. We can add a 2nd ctor at a later stage instead.

   AudioDevice();
 
-  AudioDevice(const media::AudioParameters& params, RenderCallback* callback);
-
   // AudioRendererSink implementation.
   virtual void Initialize(const media::AudioParameters& params,
                           RenderCallback* callback) OVERRIDE;