Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: runtime/vm/exceptions.cc

Issue 10537065: Debugger break on TypeError, AssertionError (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger_api_impl.cc ('k') | tools/ddbg.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/exceptions.cc
===================================================================
--- runtime/vm/exceptions.cc (revision 8456)
+++ runtime/vm/exceptions.cc (working copy)
@@ -6,6 +6,7 @@
#include "vm/cpu.h"
#include "vm/dart_entry.h"
+#include "vm/debugger.h"
#include "vm/flags.h"
#include "vm/object.h"
#include "vm/stack_frame.h"
@@ -244,8 +245,12 @@
void Exceptions::Throw(const Instance& exception) {
+ Isolate* isolate = Isolate::Current();
+ if (isolate->debugger()->IsActive()) {
+ isolate->debugger()->SignalExceptionThrown(exception);
+ }
// Null object is a valid exception object.
- ThrowExceptionHelper(exception, Instance::Handle());
+ ThrowExceptionHelper(exception, Instance::Handle(isolate));
}
« no previous file with comments | « runtime/vm/debugger_api_impl.cc ('k') | tools/ddbg.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698