Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: net/url_request/url_request_ftp_job.h

Issue 10537056: Replaced static URLRequestFtpJob factory with non-static protocol handler for FTP jobs. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed ftp_auth_cache Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_ftp_job.h
diff --git a/net/url_request/url_request_ftp_job.h b/net/url_request/url_request_ftp_job.h
index 05cbb33979c8e6aad32b4f8e93259833a28ea36c..7eaba0cf0b012a2866fc84ec60b05145fa4a509e 100644
--- a/net/url_request/url_request_ftp_job.h
+++ b/net/url_request/url_request_ftp_job.h
@@ -17,14 +17,20 @@
namespace net {
-class URLRequestContext;
+class NetworkDelegate;
+class FtpTransactionFactory;
+class FtpAuthCache;
// A URLRequestJob subclass that is built on top of FtpTransaction. It
// provides an implementation for FTP.
class URLRequestFtpJob : public URLRequestJob {
public:
- explicit URLRequestFtpJob(URLRequest* request);
+ URLRequestFtpJob(URLRequest* request,
+ NetworkDelegate* network_delegate,
+ FtpTransactionFactory* ftp_transaction_factory,
+ FtpAuthCache* ftp_auth_cache);
+ // TODO(shalev): get rid of this function in favor of FtpProtocolHandler.
static URLRequestJob* Factory(URLRequest* request,
const std::string& scheme);
@@ -69,6 +75,9 @@ class URLRequestFtpJob : public URLRequestJob {
base::WeakPtrFactory<URLRequestFtpJob> weak_factory_;
+ FtpTransactionFactory* ftp_transaction_factory_;
+ FtpAuthCache* ftp_auth_cache_;
+
DISALLOW_COPY_AND_ASSIGN(URLRequestFtpJob);
};

Powered by Google App Engine
This is Rietveld 408576698