Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: net/url_request/ftp_protocol_handler.h

Issue 10537056: Replaced static URLRequestFtpJob factory with non-static protocol handler for FTP jobs. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Added DCHECKs Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/ftp_protocol_handler.h
diff --git a/net/url_request/ftp_protocol_handler.h b/net/url_request/ftp_protocol_handler.h
new file mode 100644
index 0000000000000000000000000000000000000000..90bc57f32e97e079c6721271c4995fa411c82948
--- /dev/null
+++ b/net/url_request/ftp_protocol_handler.h
@@ -0,0 +1,34 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_URL_REQUEST_FTP_PROTOCOL_HANDLER_H_
+#define NET_URL_REQUEST_FTP_PROTOCOL_HANDLER_H_
+#pragma once
+
+#include "net/url_request/url_request_job_factory.h"
+
+namespace net {
+
+class URLRequestJob;
+class NetworkDelegate;
+class FtpTransactionFactory;
+class FtpAuthCache;
+
+class NET_EXPORT FtpProtocolHandler :
erikwright (departed) 2012/06/11 15:43:02 Add a class comment: // Implements a ProtocolHand
shalev 2012/06/21 20:04:55 Done.
+ public URLRequestJobFactory::ProtocolHandler {
+ public:
+ FtpProtocolHandler(NetworkDelegate* network_delegate,
+ FtpTransactionFactory* ftp_transaction_factory,
+ FtpAuthCache* ftp_auth_cache);
+ URLRequestJob* MaybeCreateJob(URLRequest* request) const OVERRIDE;
+ private:
+ NetworkDelegate* network_delegate_;
+ FtpTransactionFactory* ftp_transaction_factory_;
+ FtpAuthCache* ftp_auth_cache_;
+ DISALLOW_COPY_AND_ASSIGN(FtpProtocolHandler);
+};
+
+} // namespace net
+
+#endif // NET_URL_REQUEST_FTP_PROTOCOL_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698