content/renderer/rendering_benchmark_results.h - Issue 10537036: Added rendering benchmark javascript hook

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/rendering_benchmark_results.h

Issue 10537036: Added rendering benchmark javascript hook (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: added null check for support Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_RENDERER_RENDERING_BENCHMARK_RESULTS_H_

	6 #define CONTENT_RENDERER_RENDERING_BENCHMARK_RESULTS_H_

	7

	8 #include <string>

	9

	10 #include "content/common/content_export.h"

	11

	12 namespace content {

	13 class RenderingBenchmarkResults {
	jam 2012/07/23 20:45:58 nit: blank line above nit: blank line above dmurph 2012/07/23 23:25:23 Done. Show quoted text On 2012/07/23 20:45:58, John Abd-El-Malek wrote: > nit: blank line above Done.
	14 public:

	15 virtual ~RenderingBenchmarkResults();

	16

	17 virtual void addResult(const std::string& benchmark_name,
	jam 2012/07/23 20:45:58 nit: google style is AddResult nit: google style is AddResult dmurph 2012/07/23 23:25:23 Done. Show quoted text On 2012/07/23 20:45:58, John Abd-El-Malek wrote: > nit: google style is AddResult Done.
	18 const std::string& result_name,

	19 const std::string& result_unit,

	20 double time) = 0;

	21 };

	22 }

	23 #endif // CONTENT_RENDERER_RENDERING_BENCHMARK_RESULTS_H_
	jam 2012/07/23 20:45:58 nit: blank line above nit: blank line above dmurph 2012/07/23 23:25:23 Done. Show quoted text On 2012/07/23 20:45:58, John Abd-El-Malek wrote: > nit: blank line above Done.
OLD	NEW