Added rendering benchmark javascript hook

content/public/renderer/rendering_benchmark.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_RENDERER_RENDERING_BENCHMARK_H_
+#define CONTENT_PUBLIC_RENDERER_RENDERING_BENCHMARK_H_

[nduca, 2012/07/18 06:06:17]

Why is all of this public? Its only used by content, can't it all be in the
content/renderer/ folder?

[dmurph, 2012/07/18 16:31:41]

Addessed in other comment

+
+#include <string>
+
+#include "base/basictypes.h"
+#include "content/common/content_export.h"
+#include "content/public/renderer/rendering_benchmark_results.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebViewBenchmarkSupport.h"

[nduca, 2012/07/18 06:06:17]

Dont include until you use.
namespace WebKit {
class WebViewBenchmarkSupport;
}

the rule is to #include only when you actually use a class, e.g. derive from it,
use/pass it by value, or access members / deref it.

[dmurph, 2012/07/18 20:01:57]

Done.

+
+namespace content {
+class CONTENT_EXPORT RenderingBenchmark {

[nduca, 2012/07/18 06:06:17]

Dont need CONTENT_EXPORT

[dmurph, 2012/07/18 20:01:57]

Done.

+ public:
+  RenderingBenchmark(const std::string& name,
+                     RenderingBenchmarkResults* results);
+  virtual ~RenderingBenchmark();
+
+  virtual void SetUp(
+      WebKit::WebViewBenchmarkSupport* benchmarkController) {}

[nduca, 2012/07/18 06:06:17]

naming

[dmurph, 2012/07/18 20:01:57]

Done.

+
+  virtual void Run(WebKit::WebViewBenchmarkSupport*) = 0;
+
+  virtual void TearDown(
+      WebKit::WebViewBenchmarkSupport* benchmarkController) {}
+
+  const std::string& name() { return name_; }
+
+ protected:
+  void RecordResult(const std::string& result_name,

[nduca, 2012/07/18 06:06:17]

Why does this have a member variable that is the results? Why not pass it in on
the Run()?

[dmurph, 2012/07/18 16:31:41]

We talked about this earlier, it's to remove the annoying need to get the
benchmark name for recording each result (or messing up the name).  You can just
call the RecordResults method with all the values from the current test.  Plus
you get nice encapsulation of the results object.

[dmurph, 2012/07/18 20:01:57]

Removing :)

+                    const std::string& time_unit,
+                    double time);
+
+ private:
+  const std::string name_;
+  RenderingBenchmarkResults* results_;
+
+  DISALLOW_COPY_AND_ASSIGN(RenderingBenchmark);
+};
+}  // namespace content
+#endif  // CONTENT_PUBLIC_RENDERER_RENDERING_BENCHMARK_H_